From: "Andreas Färber" <afaerber@suse.de>
To: Avi Kivity <avi@redhat.com>
Cc: Bruce Rogers <brogers@suse.com>,
qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] exec.c: Fix subpage memory access to RAM MemoryRegion
Date: Fri, 09 Dec 2011 13:32:31 +0100 [thread overview]
Message-ID: <4EE1FFDF.3090100@suse.de> (raw)
In-Reply-To: <4ED7490C.7050505@redhat.com>
Am 01.12.2011 10:29, schrieb Avi Kivity:
> On 11/30/2011 05:26 PM, Andreas Färber wrote:
>> Commit 95c318f5e1f88d7e5bcc6deac17330fd4806a2d3 (Fix segfault in mmio
>> subpage handling code.) prevented a segfault by making all subpage
>> registrations over an existing memory page perform an unassigned access.
>> Symptoms were writes not taking effect and reads returning zero.
>>
>> Very small page sizes are not currently supported either,
>> so subpage memory areas cannot fully be avoided.
>>
>> Therefore change the previous fix to use a new IO_MEM_SUBPAGE_RAM
>> instead of IO_MEM_UNASSIGNED. Suggested by Avi.
>>
>>
>
> Looks reasonable. Should go into 1.1.
A formal Reviewed-by or Acked-by may help. :)
> Should we backport it to
> 1.0.blah? From 95c318f's description, it doesn't happen in normal
> circumstances.
We feel it should be backported to both 1.0.x and 0.15.x, please.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2011-12-09 12:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 15:26 [Qemu-devel] [PATCH v2] exec.c: Fix subpage memory access to RAM MemoryRegion Andreas Färber
2011-12-01 9:29 ` Avi Kivity
2011-12-01 9:37 ` Gleb Natapov
2011-12-01 9:41 ` Avi Kivity
2011-12-01 9:47 ` Gleb Natapov
2011-12-01 9:54 ` Avi Kivity
2011-12-01 10:06 ` Gleb Natapov
2011-12-01 17:18 ` Andreas Färber
2011-12-01 17:24 ` Avi Kivity
2011-12-09 12:32 ` Andreas Färber [this message]
2011-12-11 9:51 ` Avi Kivity
2011-12-15 18:09 ` Anthony Liguori
2012-08-22 16:53 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE1FFDF.3090100@suse.de \
--to=afaerber@suse.de \
--cc=avi@redhat.com \
--cc=brogers@suse.com \
--cc=gleb@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).