From: Jan Kiszka <jan.kiszka@web.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] i8254: Rework & fix interaction with HPET in legacy mode
Date: Sat, 10 Dec 2011 16:51:51 +0100 [thread overview]
Message-ID: <4EE38017.5010001@web.de> (raw)
In-Reply-To: <CAAu8pHuxCbvMoGTozxMTob9kT+gDkxDnBx-6+u1w3dGeJh6gxg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 538 bytes --]
On 2011-12-10 16:49, Blue Swirl wrote:
>>
>> +ISADevice *pit_init(int base, qemu_irq irq)
>
> Please retain this function in pc.h, or even better, introduce i8254.h.
No concerns about i8254.h, but this function does not qualify for static
inline.
>
>> +{
>> + ISADevice *dev;
>> +
>> + dev = isa_create("isa-pit");
>> + qdev_prop_set_uint32(&dev->qdev, "iobase", base);
>> + qdev_init_nofail(&dev->qdev);
>> + qdev_connect_gpio_out(&dev->qdev, 0, irq);
>> +
>> + return dev;
>> +}
>> +
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2011-12-10 15:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-10 12:28 [Qemu-devel] [PATCH 0/2] pit/hpet: Fix legacy mode switching Jan Kiszka
2011-12-10 12:28 ` [Qemu-devel] [PATCH 1/2] hpet: Save/restore cached RTC IRQ level Jan Kiszka
2011-12-10 12:28 ` [Qemu-devel] [PATCH 2/2] i8254: Rework & fix interaction with HPET in legacy mode Jan Kiszka
2011-12-10 15:49 ` Blue Swirl
2011-12-10 15:51 ` Jan Kiszka [this message]
2011-12-10 15:54 ` Blue Swirl
2011-12-10 16:03 ` Jan Kiszka
2011-12-10 16:26 ` Blue Swirl
2011-12-10 16:29 ` Jan Kiszka
2011-12-10 16:49 ` Blue Swirl
2011-12-10 15:52 ` [Qemu-devel] [PATCH 0/2] pit/hpet: Fix legacy mode switching Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE38017.5010001@web.de \
--to=jan.kiszka@web.de \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).