From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56235)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1RZPDV-0002uI-Db
	for qemu-devel@nongnu.org; Sat, 10 Dec 2011 10:52:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1RZPDU-0003Xv-6a
	for qemu-devel@nongnu.org; Sat, 10 Dec 2011 10:52:01 -0500
Received: from fmmailgate02.web.de ([217.72.192.227]:43217)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1RZPDT-0003Xq-Qb
	for qemu-devel@nongnu.org; Sat, 10 Dec 2011 10:52:00 -0500
Received: from moweb001.kundenserver.de (moweb001.kundenserver.de
	[172.19.20.114])
	by fmmailgate02.web.de (Postfix) with ESMTP id A09901BB31E2D
	for <qemu-devel@nongnu.org>; Sat, 10 Dec 2011 16:51:58 +0100 (CET)
Message-ID: <4EE38017.5010001@web.de>
Date: Sat, 10 Dec 2011 16:51:51 +0100
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <cover.1323520118.git.jan.kiszka@web.de>
	<42a283294478be02e4f1dc5b0a78421030b51bbe.1323520118.git.jan.kiszka@web.de>
	<CAAu8pHuxCbvMoGTozxMTob9kT+gDkxDnBx-6+u1w3dGeJh6gxg@mail.gmail.com>
In-Reply-To: <CAAu8pHuxCbvMoGTozxMTob9kT+gDkxDnBx-6+u1w3dGeJh6gxg@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig8D0D52E2AB7FD74DCBEFAD1B"
Subject: Re: [Qemu-devel] [PATCH 2/2] i8254: Rework & fix interaction with
 HPET in legacy mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>, Avi Kivity <avi@redhat.com>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig8D0D52E2AB7FD74DCBEFAD1B
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 2011-12-10 16:49, Blue Swirl wrote:
>>
>> +ISADevice *pit_init(int base, qemu_irq irq)
>=20
> Please retain this function in pc.h, or even better, introduce i8254.h.=


No concerns about i8254.h, but this function does not qualify for static
inline.

>=20
>> +{
>> +    ISADevice *dev;
>> +
>> +    dev =3D isa_create("isa-pit");
>> +    qdev_prop_set_uint32(&dev->qdev, "iobase", base);
>> +    qdev_init_nofail(&dev->qdev);
>> +    qdev_connect_gpio_out(&dev->qdev, 0, irq);
>> +
>> +    return dev;
>> +}
>> +

Jan


--------------enig8D0D52E2AB7FD74DCBEFAD1B
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk7jgBsACgkQitSsb3rl5xSWkACdHWDqCoqdIOhuArzpWV/dNCm1
/KUAoNHR9Xnwz1Srq3zO4TFWUHrinP+U
=05/W
-----END PGP SIGNATURE-----

--------------enig8D0D52E2AB7FD74DCBEFAD1B--