From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43152)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1RZPOU-00069S-Gz
	for qemu-devel@nongnu.org; Sat, 10 Dec 2011 11:03:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1RZPOT-00050s-3c
	for qemu-devel@nongnu.org; Sat, 10 Dec 2011 11:03:22 -0500
Received: from fmmailgate03.web.de ([217.72.192.234]:41469)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1RZPOS-00050W-NL
	for qemu-devel@nongnu.org; Sat, 10 Dec 2011 11:03:21 -0500
Received: from moweb001.kundenserver.de (moweb001.kundenserver.de
	[172.19.20.114])
	by fmmailgate03.web.de (Postfix) with ESMTP id 9F5051AB479D4
	for <qemu-devel@nongnu.org>; Sat, 10 Dec 2011 17:03:19 +0100 (CET)
Message-ID: <4EE382C5.2000200@web.de>
Date: Sat, 10 Dec 2011 17:03:17 +0100
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <cover.1323520118.git.jan.kiszka@web.de>
	<42a283294478be02e4f1dc5b0a78421030b51bbe.1323520118.git.jan.kiszka@web.de>
	<CAAu8pHuxCbvMoGTozxMTob9kT+gDkxDnBx-6+u1w3dGeJh6gxg@mail.gmail.com>
	<4EE38017.5010001@web.de>
	<CAAu8pHs4LQDkdRA7JQLWLa8ep2wiftjfirxNqNaiWHf66h1HLg@mail.gmail.com>
In-Reply-To: <CAAu8pHs4LQDkdRA7JQLWLa8ep2wiftjfirxNqNaiWHf66h1HLg@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig6135F78582FECF5A0F67E32D"
Subject: Re: [Qemu-devel] [PATCH 2/2] i8254: Rework & fix interaction with
 HPET in legacy mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>, Avi Kivity <avi@redhat.com>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig6135F78582FECF5A0F67E32D
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 2011-12-10 16:54, Blue Swirl wrote:
> On Sat, Dec 10, 2011 at 15:51, Jan Kiszka <jan.kiszka@web.de> wrote:
>> On 2011-12-10 16:49, Blue Swirl wrote:
>>>>
>>>> +ISADevice *pit_init(int base, qemu_irq irq)
>>>
>>> Please retain this function in pc.h, or even better, introduce i8254.=
h.
>>
>> No concerns about i8254.h, but this function does not qualify for stat=
ic
>> inline.
>=20
> The function is static inline in a header file not for performance
> reasons, but to keep the instantiation separate from device internals.

Not performance, footprint and header dependencies. You need to pull in
all the stuff the inline function needs for everyone including the
header that contains this function. That's messy.

Even if the instantiation helper should not poke into the device model
internals (and I don't want this to change as well), it belongs to the
module that implements the device. We do the same with other fabric
functions.

Jan


--------------enig6135F78582FECF5A0F67E32D
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk7jgsUACgkQitSsb3rl5xRRawCaAicEN5sD8ABQHQcwonJcWUv2
LoIAnj0rqee6WtoQ/yipkHeQ5DwS4f1g
=o0iV
-----END PGP SIGNATURE-----

--------------enig6135F78582FECF5A0F67E32D--