qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Evgeny Voevodin <e.voevodin@samsung.com>
Cc: m.kozlov@samsung.com, qemu-devel@nongnu.org, d.solodkiy@samsung.com
Subject: Re: [Qemu-devel] [PATCH v3 00/14] ARM: Samsung Exynos4210-based boards support.
Date: Mon, 12 Dec 2011 08:22:20 +0100	[thread overview]
Message-ID: <4EE5ABAC.2020703@weilnetz.de> (raw)
In-Reply-To: <1323672206-11891-1-git-send-email-e.voevodin@samsung.com>

Am 12.12.2011 07:43, schrieb Evgeny Voevodin:
> This set of patches adds support for Samsung S5PC210-based boards NURI 
> and SMDKC210.
> Tested on Linux kernel v3.x series. Usage of "-smp 2" option is 
> reuired for now.
>
> Third version: Reverted hw/arm_gic.c modification. Added IRQ Gate to 
> Exynos4210
> board.
>
> Evgeny Voevodin (8):
> hw/sysbus.h: Increase maximum number of device IRQs.
> ARM: exynos4210: IRQ subsystem support.
> ARM: exynos4210: PWM support.
> hw/arm_boot.c: Add new secondary CPU bootloader.
> ARM: exynos4210: MCT support.
> hw/exynos4210.c: Boot secondary CPU.
> hw/lan9118: Add basic 16-bit mode support.
> hw/exynos4210.c: Add LAN support for SMDKC210.
>
> Maksim Kozlov (3):
> ARM: Samsung exynos4210-based boards emulation
> ARM: exynos4210: CMU support
> ARM: exynos4210: UART support
>
> Mitsyanko Igor (3):
> hw/sd.c, hw/sd.h: add receive ready query routine to SD/MMC API
> ARM: exynos4210: added SD/MMC host controller
> ARM: exynos4210: added display controller implementation
>
> Makefile.target | 3 +
> hw/arm-misc.h | 1 +
> hw/arm_boot.c | 22 +-
> hw/devices.h | 2 +-
> hw/exynos4210.c | 561 +++++++++++++++
> hw/exynos4210.h | 107 +++
> hw/exynos4210_cmu.c | 1146 ++++++++++++++++++++++++++++++
> hw/exynos4210_combiner.c | 385 ++++++++++
> hw/exynos4210_fimd.c | 1737 ++++++++++++++++++++++++++++++++++++++++++++++
> hw/exynos4210_gic.c | 510 ++++++++++++++
> hw/exynos4210_mct.c | 1486 +++++++++++++++++++++++++++++++++++++++
> hw/exynos4210_pwm.c | 433 ++++++++++++
> hw/exynos4210_sdhc.c | 1666 ++++++++++++++++++++++++++++++++++++++++++++
> hw/exynos4210_uart.c | 674 ++++++++++++++++++
> hw/lan9118.c | 115 +++-
> hw/sd.c | 5 +
> hw/sd.h | 1 +
> hw/sysbus.h | 2 +-
> 18 files changed, 8840 insertions(+), 16 deletions(-)
> create mode 100644 hw/exynos4210.c
> create mode 100644 hw/exynos4210.h
> create mode 100644 hw/exynos4210_cmu.c
> create mode 100644 hw/exynos4210_combiner.c
> create mode 100644 hw/exynos4210_fimd.c
> create mode 100644 hw/exynos4210_gic.c
> create mode 100644 hw/exynos4210_mct.c
> create mode 100644 hw/exynos4210_pwm.c
> create mode 100644 hw/exynos4210_sdhc.c
> create mode 100644 hw/exynos4210_uart.c

I did not review you patches, but noticed that they still include
the FSF address (which changed several times in the past):

    You should have received a copy of the GNU General Public License along
    with this program; if not, write to the Free Software Foundation, 
Inc., 51
    Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA

To avoid future address change modifications, most QEMU
code uses this statement in the license comments:

    You should have received a copy of the GNU General Public License
    along with this program; if not, see <http://www.gnu.org/licenses/>.

If a new version of your patches is needed, you might change that
as well.

Regards,
Stefan Weil

  parent reply	other threads:[~2011-12-12  7:23 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12  6:43 [Qemu-devel] [PATCH v3 00/14] ARM: Samsung Exynos4210-based boards support Evgeny Voevodin
2011-12-12  6:43 ` [Qemu-devel] [PATCH v3 01/14] ARM: Samsung exynos4210-based boards emulation Evgeny Voevodin
2011-12-12 22:17   ` Peter Maydell
2011-12-12  6:43 ` [Qemu-devel] [PATCH v3 02/14] ARM: exynos4210: CMU support Evgeny Voevodin
2011-12-12 22:44   ` Peter Maydell
2011-12-14 12:10     ` Maksim E. Kozlov
2011-12-14 11:43       ` Peter Maydell
2011-12-14 17:08     ` Maksim E. Kozlov
2011-12-14 16:25       ` Peter Maydell
2011-12-15  7:11     ` Dmitry Solodkiy
2011-12-12  6:43 ` [Qemu-devel] [PATCH v3 03/14] ARM: exynos4210: UART support Evgeny Voevodin
2011-12-12 22:55   ` Peter Maydell
2011-12-12  6:43 ` [Qemu-devel] [PATCH v3 04/14] hw/sysbus.h: Increase maximum number of device IRQs Evgeny Voevodin
2011-12-12  6:43 ` [Qemu-devel] [PATCH v3 05/14] ARM: exynos4210: IRQ subsystem support Evgeny Voevodin
2011-12-12  6:43 ` [Qemu-devel] [PATCH v3 06/14] ARM: exynos4210: PWM support Evgeny Voevodin
2011-12-13 10:51   ` Peter Maydell
2011-12-12  6:43 ` [Qemu-devel] [PATCH v3 07/14] hw/arm_boot.c: Add new secondary CPU bootloader Evgeny Voevodin
2011-12-13 11:28   ` Peter Maydell
2011-12-12  6:43 ` [Qemu-devel] [PATCH v3 08/14] ARM: exynos4210: MCT support Evgeny Voevodin
2011-12-12  6:43 ` [Qemu-devel] [PATCH v3 09/14] hw/exynos4210.c: Boot secondary CPU Evgeny Voevodin
2011-12-12  6:43 ` [Qemu-devel] [PATCH v3 10/14] hw/lan9118: Add basic 16-bit mode support Evgeny Voevodin
2011-12-13 11:54   ` Peter Maydell
2011-12-12  6:43 ` [Qemu-devel] [PATCH v3 11/14] hw/exynos4210.c: Add LAN support for SMDKC210 Evgeny Voevodin
2011-12-13 12:01   ` Peter Maydell
2011-12-12  6:43 ` [Qemu-devel] [PATCH v3 12/14] hw/sd.c, hw/sd.h: add receive ready query routine to SD/MMC API Evgeny Voevodin
2011-12-13 15:11   ` Peter Maydell
2011-12-13 16:22     ` Peter Maydell
2011-12-14  8:29       ` Mitsyanko Igor
2011-12-12  6:43 ` [Qemu-devel] [PATCH v3 13/14] ARM: exynos4210: added SD/MMC host controller Evgeny Voevodin
2011-12-13 14:56   ` Peter Maydell
2011-12-13 16:23     ` Mitsyanko Igor
2011-12-12  6:43 ` [Qemu-devel] [PATCH v3 14/14] ARM: exynos4210: added display controller implementation Evgeny Voevodin
2011-12-12  7:22 ` Stefan Weil [this message]
2011-12-13 10:14 ` [Qemu-devel] [PATCH v3 00/14] ARM: Samsung Exynos4210-based boards support Peter Maydell
2011-12-13 10:37   ` Dmitry Solodkiy
2011-12-13 10:59     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE5ABAC.2020703@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=d.solodkiy@samsung.com \
    --cc=e.voevodin@samsung.com \
    --cc=m.kozlov@samsung.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).