qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Alex Bligh <alex@alex.org.uk>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] RFC: raw device support for block device targets
Date: Mon, 12 Dec 2011 10:48:43 +0100	[thread overview]
Message-ID: <4EE5CDFB.1080809@redhat.com> (raw)
In-Reply-To: <98D05E44527FF395E0A60016@nimrod.local>

Am 11.12.2011 11:45, schrieb Alex Bligh:
> 
> 
> --On 8 December 2011 13:40:57 +0100 Kevin Wolf <kwolf@redhat.com> wrote:
> 
>>> qemu-img convert appears to support block devices as input, but not
>>> as output. That is irritating, as when using qemu-img convert to
>>> convert qcow to raw on a block partition, an intermediate file has
>>> to be used, which slows things down and pointlessly uses disk space.
>>>
>>> The problem is that ftruncate() is being called on the output file
>>> in order ensure it is sufficiently large, and this fails on
>>> block devices.
> ...
>>
>> Creating an image on a block device shouldn't even call raw_create(),
>> but only hdev_create(), which doesn't try to truncate the device, but
>> just uses lseek to make sure that it's large enough.
>>
>> Which qemu version are you using and what's your command line?
> 
> I was testing on:
> 
> amb@alex-test:~$ qemu-img --version
> qemu-img version 0.12.3, Copyright (c) 2004-2008 Fabrice Bellard

That's the problem. It should work since 0.13.

Kevin

  reply	other threads:[~2011-12-12  9:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-06 16:20 [Qemu-devel] RFC: raw device support for block device targets Alex Bligh
2011-12-06 18:42 ` Christoph Hellwig
2011-12-06 19:28   ` Alex Bligh
2011-12-08 12:40 ` Kevin Wolf
2011-12-11 10:45   ` Alex Bligh
2011-12-12  9:48     ` Kevin Wolf [this message]
2011-12-12 10:32       ` Alex Bligh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE5CDFB.1080809@redhat.com \
    --to=kwolf@redhat.com \
    --cc=alex@alex.org.uk \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).