qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: "Hervé Poussineau" <hpoussin@reactos.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 02/11] isa: move ISABus structure definition to header file
Date: Mon, 12 Dec 2011 10:39:10 -0600	[thread overview]
Message-ID: <4EE62E2E.3040705@codemonkey.ws> (raw)
In-Reply-To: <1319487505-5915-3-git-send-email-hpoussin@reactos.org>

On 10/24/2011 03:18 PM, Hervé Poussineau wrote:
>
> Signed-off-by: Hervé Poussineau<hpoussin@reactos.org>

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

> ---
>   hw/isa-bus.c |    5 -----
>   hw/isa.h     |    6 ++++++
>   2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/hw/isa-bus.c b/hw/isa-bus.c
> index dcbb134..7c94f0b 100644
> --- a/hw/isa-bus.c
> +++ b/hw/isa-bus.c
> @@ -22,11 +22,6 @@
>   #include "isa.h"
>   #include "exec-memory.h"
>
> -struct ISABus {
> -    BusState qbus;
> -    MemoryRegion *address_space_io;
> -    qemu_irq *irqs;
> -};
>   static ISABus *isabus;
>   target_phys_addr_t isa_mem_base = 0;
>
> diff --git a/hw/isa.h b/hw/isa.h
> index 4b58e37..0462521 100644
> --- a/hw/isa.h
> +++ b/hw/isa.h
> @@ -13,6 +13,12 @@ typedef struct ISABus ISABus;
>   typedef struct ISADevice ISADevice;
>   typedef struct ISADeviceInfo ISADeviceInfo;
>
> +struct ISABus {
> +    BusState qbus;
> +    MemoryRegion *address_space_io;
> +    qemu_irq *irqs;
> +};
> +
>   struct ISADevice {
>       DeviceState qdev;
>       uint32_t isairq[2];

  reply	other threads:[~2011-12-12 16:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-24 20:18 [Qemu-devel] [PATCH 00/11] isa: preliminary work for multiple buses Hervé Poussineau
2011-10-24 20:18 ` [Qemu-devel] [PATCH 01/11] isa: give ISABus/ISADevice to isa_create(), isa_bus_irqs() and isa_get_irq() functions Hervé Poussineau
2011-12-12 16:38   ` Anthony Liguori
2011-10-24 20:18 ` [Qemu-devel] [PATCH 02/11] isa: move ISABus structure definition to header file Hervé Poussineau
2011-12-12 16:39   ` Anthony Liguori [this message]
2011-10-24 20:18 ` [Qemu-devel] [PATCH 03/11] i8259: give ISA device to isa_register_ioport() Hervé Poussineau
2011-12-12 16:39   ` Anthony Liguori
2011-10-24 20:18 ` [Qemu-devel] [PATCH 04/11] pc: give ISA bus to ISA methods Hervé Poussineau
2011-12-12 16:40   ` Anthony Liguori
2011-10-24 20:18 ` [Qemu-devel] [PATCH 05/11] alpha: " Hervé Poussineau
2011-10-24 20:18 ` [Qemu-devel] [PATCH 06/11] sun4u: " Hervé Poussineau
2011-10-24 20:18 ` [Qemu-devel] [PATCH 07/11] fulong2e: " Hervé Poussineau
2011-10-24 20:18 ` [Qemu-devel] [PATCH 08/11] malta: " Hervé Poussineau
2011-10-24 20:18 ` [Qemu-devel] [PATCH 09/11] isa: always use provided ISA bus when creating an isa device Hervé Poussineau
2011-10-24 20:18 ` [Qemu-devel] [PATCH 10/11] isa: always use provided ISA bus in isa_bus_irqs() Hervé Poussineau
2011-10-24 20:18 ` [Qemu-devel] [PATCH 11/11] audio: remove unused parameter isa_pic Hervé Poussineau
2011-10-28 17:24 ` [Qemu-devel] [PATCH 00/11] isa: preliminary work for multiple buses Hervé Poussineau
2011-11-05  8:27   ` Hervé Poussineau
2011-12-12 16:41 ` Anthony Liguori
  -- strict thread matches above, loose matches on Subject: below --
2011-12-14 23:02 [Qemu-devel] [PATCH v2 " Hervé Poussineau
2011-12-14 23:02 ` [Qemu-devel] [PATCH 02/11] isa: move ISABus structure definition to header file Hervé Poussineau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE62E2E.3040705@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=hpoussin@reactos.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).