From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43579)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Ra8uM-0001FW-7i
	for qemu-devel@nongnu.org; Mon, 12 Dec 2011 11:39:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Ra8uH-0000tb-SD
	for qemu-devel@nongnu.org; Mon, 12 Dec 2011 11:39:18 -0500
Received: from mail-qy0-f173.google.com ([209.85.216.173]:35794)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Ra8uH-0000tS-Pp
	for qemu-devel@nongnu.org; Mon, 12 Dec 2011 11:39:13 -0500
Received: by qcsd15 with SMTP id d15so4388342qcs.4
	for <qemu-devel@nongnu.org>; Mon, 12 Dec 2011 08:39:13 -0800 (PST)
Message-ID: <4EE62E2E.3040705@codemonkey.ws>
Date: Mon, 12 Dec 2011 10:39:10 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1319487505-5915-1-git-send-email-hpoussin@reactos.org>
	<1319487505-5915-3-git-send-email-hpoussin@reactos.org>
In-Reply-To: <1319487505-5915-3-git-send-email-hpoussin@reactos.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 02/11] isa: move ISABus structure
 definition to header file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>
Cc: qemu-devel@nongnu.org

On 10/24/2011 03:18 PM, Hervé Poussineau wrote:
>
> Signed-off-by: Hervé Poussineau<hpoussin@reactos.org>

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

> ---
>   hw/isa-bus.c |    5 -----
>   hw/isa.h     |    6 ++++++
>   2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/hw/isa-bus.c b/hw/isa-bus.c
> index dcbb134..7c94f0b 100644
> --- a/hw/isa-bus.c
> +++ b/hw/isa-bus.c
> @@ -22,11 +22,6 @@
>   #include "isa.h"
>   #include "exec-memory.h"
>
> -struct ISABus {
> -    BusState qbus;
> -    MemoryRegion *address_space_io;
> -    qemu_irq *irqs;
> -};
>   static ISABus *isabus;
>   target_phys_addr_t isa_mem_base = 0;
>
> diff --git a/hw/isa.h b/hw/isa.h
> index 4b58e37..0462521 100644
> --- a/hw/isa.h
> +++ b/hw/isa.h
> @@ -13,6 +13,12 @@ typedef struct ISABus ISABus;
>   typedef struct ISADevice ISADevice;
>   typedef struct ISADeviceInfo ISADeviceInfo;
>
> +struct ISABus {
> +    BusState qbus;
> +    MemoryRegion *address_space_io;
> +    qemu_irq *irqs;
> +};
> +
>   struct ISADevice {
>       DeviceState qdev;
>       uint32_t isairq[2];