From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:34948)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Ra8us-0002N7-OA
	for qemu-devel@nongnu.org; Mon, 12 Dec 2011 11:39:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Ra8uq-00010t-8N
	for qemu-devel@nongnu.org; Mon, 12 Dec 2011 11:39:50 -0500
Received: from mail-iy0-f173.google.com ([209.85.210.173]:57882)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Ra8uq-00010h-4D
	for qemu-devel@nongnu.org; Mon, 12 Dec 2011 11:39:48 -0500
Received: by iagj37 with SMTP id j37so2907245iag.4
	for <qemu-devel@nongnu.org>; Mon, 12 Dec 2011 08:39:47 -0800 (PST)
Message-ID: <4EE62E50.40906@codemonkey.ws>
Date: Mon, 12 Dec 2011 10:39:44 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1319487505-5915-1-git-send-email-hpoussin@reactos.org>
	<1319487505-5915-4-git-send-email-hpoussin@reactos.org>
In-Reply-To: <1319487505-5915-4-git-send-email-hpoussin@reactos.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 03/11] i8259: give ISA device to
	isa_register_ioport()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>
Cc: qemu-devel@nongnu.org

On 10/24/2011 03:18 PM, Hervé Poussineau wrote:
>
> Signed-off-by: Hervé Poussineau<hpoussin@reactos.org>

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

> ---
>   hw/i8259.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/i8259.c b/hw/i8259.c
> index 4446339..7331e0e 100644
> --- a/hw/i8259.c
> +++ b/hw/i8259.c
> @@ -469,9 +469,9 @@ static int pic_initfn(ISADevice *dev)
>       memory_region_init_io(&s->base_io,&pic_base_ioport_ops, s, "pic", 2);
>       memory_region_init_io(&s->elcr_io,&pic_elcr_ioport_ops, s, "elcr", 1);
>
> -    isa_register_ioport(NULL,&s->base_io, s->iobase);
> +    isa_register_ioport(dev,&s->base_io, s->iobase);
>       if (s->elcr_addr != -1) {
> -        isa_register_ioport(NULL,&s->elcr_io, s->elcr_addr);
> +        isa_register_ioport(dev,&s->elcr_io, s->elcr_addr);
>       }
>
>       qdev_init_gpio_out(&dev->qdev, s->int_out, ARRAY_SIZE(s->int_out));