From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49994)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1RaEuL-0001sP-RK
	for qemu-devel@nongnu.org; Mon, 12 Dec 2011 18:03:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1RaEuK-0002I1-Rz
	for qemu-devel@nongnu.org; Mon, 12 Dec 2011 18:03:41 -0500
Received: from e2.ny.us.ibm.com ([32.97.182.142]:36840)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1RaEuK-0002Hx-My
	for qemu-devel@nongnu.org; Mon, 12 Dec 2011 18:03:40 -0500
Received: from /spool/local
	by e2.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aliguori@us.ibm.com>;
	Mon, 12 Dec 2011 18:03:40 -0500
Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	pBCN3bFW330192
	for <qemu-devel@nongnu.org>; Mon, 12 Dec 2011 18:03:37 -0500
Received: from d01av03.pok.ibm.com (loopback [127.0.0.1])
	by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	pBCN3ZSc011949
	for <qemu-devel@nongnu.org>; Mon, 12 Dec 2011 21:03:36 -0200
Message-ID: <4EE68846.4010101@us.ibm.com>
Date: Mon, 12 Dec 2011 17:03:34 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <1323275584-8751-1-git-send-email-agl@us.ibm.com>
In-Reply-To: <1323275584-8751-1-git-send-email-agl@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] build: Cleanup qga make output
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Adam Litke <agl@us.ibm.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>

On 12/07/2011 10:33 AM, Adam Litke wrote:
> Currently the make variable qapi-dir refers to the qapi-generated directory in
> absolute terms.  This causes the harmless but ugly make output below.  By
> changing this variable to the relative path the output conforms to the norm and
> the build works fine.
>
> Before patch:
>    CC    /home/aglitke/src/qemu/qapi-generated/qga-qapi-types.o
>    CC    /home/aglitke/src/qemu/qapi-generated/qga-qapi-visit.o
>    CC    /home/aglitke/src/qemu/qapi-generated/qga-qmp-marshal.o
> After patch:
>    CC    qapi-generated/qga-qapi-types.o
>    CC    qapi-generated/qga-qapi-visit.o
>    CC    qapi-generated/qga-qmp-marshal.o

This was supposedly to fix a build issue that I was never able to reproduce.  I 
think Luiz could reproduce it though.  Luiz, could you try out Adam's patch and 
confirm it breaks for you?

Regards,

Anthony Liguori

>
> Signed-off-by: Adam Litke<agl@us.ibm.com>
> ---
>   Makefile |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 301c75e..7c93739 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -168,7 +168,7 @@ check-qjson: check-qjson.o $(qobject-obj-y) $(tools-obj-y)
>   test-coroutine: test-coroutine.o qemu-timer-common.o async.o $(coroutine-obj-y) $(tools-obj-y)
>
>   $(qapi-obj-y): $(GENERATED_HEADERS)
> -qapi-dir := $(BUILD_DIR)/qapi-generated
> +qapi-dir := qapi-generated
>   test-visitor.o test-qmp-commands.o qemu-ga$(EXESUF): QEMU_CFLAGS += -I $(qapi-dir)
>   qemu-ga$(EXESUF): LIBS = $(LIBS_QGA)
>