From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaFSR-0003yo-To for qemu-devel@nongnu.org; Mon, 12 Dec 2011 18:38:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RaFSQ-0008E7-Ml for qemu-devel@nongnu.org; Mon, 12 Dec 2011 18:38:55 -0500 Received: from e37.co.us.ibm.com ([32.97.110.158]:42467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaFSQ-0008Dv-F8 for qemu-devel@nongnu.org; Mon, 12 Dec 2011 18:38:54 -0500 Received: from /spool/local by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 12 Dec 2011 16:38:52 -0700 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pBCNcbDg111644 for ; Mon, 12 Dec 2011 16:38:37 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pBCNcbjW025404 for ; Mon, 12 Dec 2011 16:38:37 -0700 Message-ID: <4EE6907C.3010901@linux.vnet.ibm.com> Date: Mon, 12 Dec 2011 17:38:36 -0600 From: Michael Roth MIME-Version: 1.0 References: <1323275584-8751-1-git-send-email-agl@us.ibm.com> <4EE68846.4010101@us.ibm.com> In-Reply-To: <4EE68846.4010101@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] build: Cleanup qga make output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Luiz Capitulino , qemu-devel@nongnu.org, Adam Litke On 12/12/2011 05:03 PM, Anthony Liguori wrote: > On 12/07/2011 10:33 AM, Adam Litke wrote: >> Currently the make variable qapi-dir refers to the qapi-generated >> directory in >> absolute terms. This causes the harmless but ugly make output below. By >> changing this variable to the relative path the output conforms to the >> norm and >> the build works fine. >> >> Before patch: >> CC /home/aglitke/src/qemu/qapi-generated/qga-qapi-types.o >> CC /home/aglitke/src/qemu/qapi-generated/qga-qapi-visit.o >> CC /home/aglitke/src/qemu/qapi-generated/qga-qmp-marshal.o >> After patch: >> CC qapi-generated/qga-qapi-types.o >> CC qapi-generated/qga-qapi-visit.o >> CC qapi-generated/qga-qmp-marshal.o > > This was supposedly to fix a build issue that I was never able to > reproduce. I think Luiz could reproduce it though. Luiz, could you try > out Adam's patch and confirm it breaks for you? I think that was Stefano: http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg02752.html Stefano had a patch that fixed a build breakage he saw with dirty directories by setting: qapi-dir := $(SRC_DIR)/qapi-generated That patch ended up breaking the build for others, however, and was reverted. This patch was an improvement on the original, but we'd all agreed that it wasn't necessary since we don't support working around issues related to dirty directories. So if it's ugly, we can safely drop it. > > Regards, > > Anthony Liguori > >> >> Signed-off-by: Adam Litke >> --- >> Makefile | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index 301c75e..7c93739 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -168,7 +168,7 @@ check-qjson: check-qjson.o $(qobject-obj-y) >> $(tools-obj-y) >> test-coroutine: test-coroutine.o qemu-timer-common.o async.o >> $(coroutine-obj-y) $(tools-obj-y) >> >> $(qapi-obj-y): $(GENERATED_HEADERS) >> -qapi-dir := $(BUILD_DIR)/qapi-generated >> +qapi-dir := qapi-generated >> test-visitor.o test-qmp-commands.o qemu-ga$(EXESUF): QEMU_CFLAGS += -I >> $(qapi-dir) >> qemu-ga$(EXESUF): LIBS = $(LIBS_QGA) >> > >