qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
	Luiz Capitulino <lcapitulino@redhat.com>,
	Yonit Halperin <yhalperi@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC
Date: Tue, 13 Dec 2011 11:06:50 +0100	[thread overview]
Message-ID: <4EE723BA.5040602@redhat.com> (raw)
In-Reply-To: <4EE63F98.20504@codemonkey.ws>

  Hi,

> We aren't breaking an ABI here.  libvirt can detect that this command is
> gone and probe for the new command.

Please stop this.  There are libvirt versions in the wild which can't
deal with this and thus will break, no matter how hard you try to wave
it away.  The question is not whenever something breaks or not, the
question is how to deal with the breakage best.

Zapping async monitor commands *now* (i.e. early in the 1.1 release
cycle) is probably the best way to handle it.  It gives the libvirt
folks time to get a new release out of the door before 1.1-final is
released, which in turn allows distros to minimize the user-visible fallout.

Technically the switch is easy: migrate_connect_complete_cb() is called
from spice-server on completion, we just have to emit a qmp event there
instead of calling the monitor completion callback.

cheers,
  Gerd

  parent reply	other threads:[~2011-12-13 10:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-08 19:45 [Qemu-devel] Dropping the MONITOR_CMD_ASYNC Luiz Capitulino
2011-12-11 10:29 ` Alon Levy
2011-12-12 10:18   ` Stefan Hajnoczi
2011-12-12 11:29     ` Gerd Hoffmann
2011-12-12 12:10       ` Stefan Hajnoczi
2011-12-12 12:39         ` Gerd Hoffmann
2011-12-12 15:23           ` Stefan Hajnoczi
2011-12-12 16:00             ` Alon Levy
2011-12-12 16:24               ` Anthony Liguori
2011-12-12 17:22                 ` Alon Levy
2011-12-12 17:53                   ` Anthony Liguori
2011-12-13  9:03                     ` Alon Levy
2011-12-13 13:34                       ` Anthony Liguori
2011-12-13 10:06                     ` Gerd Hoffmann [this message]
2011-12-12 16:23   ` Anthony Liguori
2011-12-12 15:50 ` Alon Levy
2011-12-12 16:08   ` Luiz Capitulino
2011-12-12 16:26     ` Anthony Liguori
2011-12-13 11:06       ` Avi Kivity
2011-12-13 13:36         ` Anthony Liguori
2011-12-13 14:47           ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE723BA.5040602@redhat.com \
    --to=kraxel@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@linux.vnet.ibm.com \
    --cc=yhalperi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).