From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel <qemu-devel@nongnu.org>, Alon Levy <alevy@redhat.com>,
kraxel@redhat.com, stefanha@linux.vnet.ibm.com,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC
Date: Tue, 13 Dec 2011 13:06:32 +0200 [thread overview]
Message-ID: <4EE731B8.5000701@redhat.com> (raw)
In-Reply-To: <4EE62B2F.4070408@codemonkey.ws>
On 12/12/2011 06:26 PM, Anthony Liguori wrote:
>
> Nope, it has to be dropped.
>
> Commands using CMD_ASYNC may fail in arbitrary ways because of the way
> error reporting is done. This is an unfixable problem until we
> eliminate all uses of qerror_report().
>
Why don't we eliminate all uses for qerror_report() then? Breaking our
interfaces instead seems like a horrible idea.
> We need to take the hit here and force the command to always fail.
> libvirt will need logic to use a different command with new versions.
> If we coordinate this with the libvirt folks, we can make the
> transition as smooth as possible.
I thought we've outgrown this. If we provide an interface, we should
support it.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-12-13 11:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 19:45 [Qemu-devel] Dropping the MONITOR_CMD_ASYNC Luiz Capitulino
2011-12-11 10:29 ` Alon Levy
2011-12-12 10:18 ` Stefan Hajnoczi
2011-12-12 11:29 ` Gerd Hoffmann
2011-12-12 12:10 ` Stefan Hajnoczi
2011-12-12 12:39 ` Gerd Hoffmann
2011-12-12 15:23 ` Stefan Hajnoczi
2011-12-12 16:00 ` Alon Levy
2011-12-12 16:24 ` Anthony Liguori
2011-12-12 17:22 ` Alon Levy
2011-12-12 17:53 ` Anthony Liguori
2011-12-13 9:03 ` Alon Levy
2011-12-13 13:34 ` Anthony Liguori
2011-12-13 10:06 ` Gerd Hoffmann
2011-12-12 16:23 ` Anthony Liguori
2011-12-12 15:50 ` Alon Levy
2011-12-12 16:08 ` Luiz Capitulino
2011-12-12 16:26 ` Anthony Liguori
2011-12-13 11:06 ` Avi Kivity [this message]
2011-12-13 13:36 ` Anthony Liguori
2011-12-13 14:47 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE731B8.5000701@redhat.com \
--to=avi@redhat.com \
--cc=alevy@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).