From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaQC5-0004MN-3r for qemu-devel@nongnu.org; Tue, 13 Dec 2011 06:06:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RaQC0-0002n2-Kw for qemu-devel@nongnu.org; Tue, 13 Dec 2011 06:06:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32526) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaQC0-0002mw-Bx for qemu-devel@nongnu.org; Tue, 13 Dec 2011 06:06:40 -0500 Message-ID: <4EE731B8.5000701@redhat.com> Date: Tue, 13 Dec 2011 13:06:32 +0200 From: Avi Kivity MIME-Version: 1.0 References: <20111208174544.325838a6@doriath> <20111212155046.GB29447@garlic.tlv.redhat.com> <20111212140800.11873fa8@doriath> <4EE62B2F.4070408@codemonkey.ws> In-Reply-To: <4EE62B2F.4070408@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel , Alon Levy , kraxel@redhat.com, stefanha@linux.vnet.ibm.com, Luiz Capitulino On 12/12/2011 06:26 PM, Anthony Liguori wrote: > > Nope, it has to be dropped. > > Commands using CMD_ASYNC may fail in arbitrary ways because of the way > error reporting is done. This is an unfixable problem until we > eliminate all uses of qerror_report(). > Why don't we eliminate all uses for qerror_report() then? Breaking our interfaces instead seems like a horrible idea. > We need to take the hit here and force the command to always fail. > libvirt will need logic to use a different command with new versions. > If we coordinate this with the libvirt folks, we can make the > transition as smooth as possible. I thought we've outgrown this. If we provide an interface, we should support it. -- error compiling committee.c: too many arguments to function