From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaRpO-0003FL-QV for qemu-devel@nongnu.org; Tue, 13 Dec 2011 07:51:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RaRpK-0007LF-Kw for qemu-devel@nongnu.org; Tue, 13 Dec 2011 07:51:26 -0500 Received: from e32.co.us.ibm.com ([32.97.110.150]:42416) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaRpK-0007LB-FH for qemu-devel@nongnu.org; Tue, 13 Dec 2011 07:51:22 -0500 Received: from /spool/local by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 13 Dec 2011 05:51:21 -0700 Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pBDCpIwd101202 for ; Tue, 13 Dec 2011 05:51:18 -0700 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pBDCpInk017913 for ; Tue, 13 Dec 2011 05:51:18 -0700 Message-ID: <4EE74A45.8000306@linux.vnet.ibm.com> Date: Tue, 13 Dec 2011 07:51:17 -0500 From: Stefan Berger MIME-Version: 1.0 References: <1323717136-21661-1-git-send-email-stefanb@linux.vnet.ibm.com> <4EE68DFF.6050908@codemonkey.ws> <4EE6987F.1000100@linux.vnet.ibm.com> <201112130451.44284.paul@codesourcery.com> In-Reply-To: <201112130451.44284.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V13 6/7] Introduce --enable-tpm-passthrough configure option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: andreas.niederl@iaik.tugraz.at, qemu-devel@nongnu.org, mst@redhat.com On 12/12/2011 11:51 PM, Paul Brook wrote: >>>> +tpm_passthrough="no" >>> Same as before, please probe for existence. >> We would be probing for /dev/tpm0. Is that really what we want that this >> driver only gets compiled if /dev/tpm0 is (currently) available? > If what you say is true then this code should always be enabled. > Michael Tsirkin previously requested that there be an option for the TPM passthrough driver to be selectively enabled since at least using /dev/tpm0 may not be what everybody wants. The passthrough driver at some point will also be able to use sockets to communicate with a TPM when a file descriptor is passed to Qemu, so maybe that changes then? Stefan