From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41510) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaSVg-00039j-SL for qemu-devel@nongnu.org; Tue, 13 Dec 2011 08:35:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RaSVc-0008To-VX for qemu-devel@nongnu.org; Tue, 13 Dec 2011 08:35:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:23808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaSVc-0008T0-LT for qemu-devel@nongnu.org; Tue, 13 Dec 2011 08:35:04 -0500 Message-ID: <4EE75480.5080003@redhat.com> Date: Tue, 13 Dec 2011 14:34:56 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1323739340-11364-1-git-send-email-mars@linux.vnet.ibm.com> In-Reply-To: <1323739340-11364-1-git-send-email-mars@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V2] Fix parse of usb device description with multiple configurations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mars@linux.vnet.ibm.com Cc: qemu-devel@nongnu.org On 12/13/11 02:22, mars@linux.vnet.ibm.com wrote: > When testing ipod on QEMU by He Jie Xu,qemu made a assertion. > We found that the ipod with 2 configurations,and the usb-linux did not parse the descriptor correctly. > The descr_len returned is the total length of the all configurations,not one configuration. > The older version will through the other configurations instead of skip,continue parsing the descriptor of interfaces/endpoints in other configurations,then went wrong. > > This patch will put the configuration descriptor parse in loop outside and dispel the other configurations not requested. Patch added to usb patch queue. thanks, Gerd