qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Markus Armbruster <armbru@redhat.com>,
	Avi Kivity <avi@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [RFC] QEMU Object Model status/merge plan
Date: Tue, 13 Dec 2011 16:05:24 +0100	[thread overview]
Message-ID: <4EE769B4.2020403@redhat.com> (raw)
In-Reply-To: <4EE7567E.3070702@codemonkey.ws>

Am 13.12.2011 14:43, schrieb Anthony Liguori:
> On 12/13/2011 05:35 AM, Stefan Hajnoczi wrote:
>> On Mon, Dec 12, 2011 at 7:36 PM, Anthony Liguori<anthony@codemonkey.ws>  wrote:
>>> I choose the serial device to showcase what we'll eventually be able to do.
>>>   The three relevant files are:
>>>
>>> https://github.com/aliguori/qemu/blob/qom-next/hw/isa-serial.c
>>>
>>> https://github.com/aliguori/qemu/blob/qom-next/hw/mm-serial.c
>>>
>>> https://github.com/aliguori/qemu/blob/qom-next/hw/serial.c
>>
>> I'm not sure I understand how init functions are called for derived
>> classes.
> 
> There are three types of init functions:
> 
> class_init
> ==========
> 
> This lives in (TypeInit) and is called when a class is first created for a type. 
>   It is only ever called once.  Within this function, you should override any 
> methods in your base classes and set default implementations for any methods you 
> implement.

I guess in most cases this could be replaced by a static table and the
function could be made optional? (That is, there could be a default
implementation for the NULL case)

> instance_init
> =============
> 
> This is the constructor for a type.  It is called when an object is created and 
> chained such that the base class constructors are called first to initialize the 
> object.

Same for this one, in your serial code it looks like this doesn't do
anything interesting in the common case and could be made optional (it
adds an UART child device, but this is static property and should be
moved anyway)

I think even in the future the really interesting work will be done in
realize.

Kevin

  reply	other threads:[~2011-12-13 15:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12 19:36 [Qemu-devel] [RFC] QEMU Object Model status/merge plan Anthony Liguori
2011-12-13 11:35 ` Stefan Hajnoczi
2011-12-13 13:43   ` Anthony Liguori
2011-12-13 15:05     ` Kevin Wolf [this message]
2011-12-13 16:02       ` Anthony Liguori
2011-12-14 10:33         ` Kevin Wolf
2011-12-14 13:46           ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE769B4.2020403@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=armbru@redhat.com \
    --cc=avi@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).