qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Alex Rozenman <Alex_Rozenman@mentor.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel <qemu-devel@nongnu.org>,
	Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] Initial support for ARM V6-M
Date: Tue, 13 Dec 2011 19:11:29 +0100	[thread overview]
Message-ID: <4EE79551.4030400@suse.de> (raw)
In-Reply-To: <1323798248.18910.3.camel@petersburg>

Hi,

Am 13.12.2011 18:44, schrieb Alex Rozenman:
> Please review / discuss / push the attched patch. It adds initial
> support for V6-M for ARM and Cortex-M0.

Please send this as an inline patch (git send-email) and cc Peter.

Some comments:

Please rebase against Peter's target-arm branch:

http://git.linaro.org/gitweb?p=people/pmaydell/qemu-arm.git;a=shortlog;h=refs/heads/target-arm.next

You can drop V4T and V5 features then.

IS_V7M() does not seem to be used anywhere yet.

Looks good otherwise AFAICT.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  parent reply	other threads:[~2011-12-13 18:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-13 17:44 [Qemu-devel] [PATCH] Initial support for ARM V6-M Alex Rozenman
2011-12-13 18:05 ` Peter Maydell
2011-12-14  9:55   ` Alex Rozenman
2011-12-14 10:06     ` Peter Maydell
2011-12-13 18:11 ` Andreas Färber [this message]
2011-12-13 23:13   ` Peter Maydell
2011-12-13 18:19 ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE79551.4030400@suse.de \
    --to=afaerber@suse.de \
    --cc=Alex_Rozenman@mentor.com \
    --cc=paul@codesourcery.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).