From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51932)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RaWqI-0006AO-QR
	for qemu-devel@nongnu.org; Tue, 13 Dec 2011 13:12:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RaWqE-0001LX-JG
	for qemu-devel@nongnu.org; Tue, 13 Dec 2011 13:12:42 -0500
Received: from cantor2.suse.de ([195.135.220.15]:58324 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RaWqE-0001LK-EW
	for qemu-devel@nongnu.org; Tue, 13 Dec 2011 13:12:38 -0500
Message-ID: <4EE79551.4030400@suse.de>
Date: Tue, 13 Dec 2011 19:11:29 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1323798248.18910.3.camel@petersburg>
In-Reply-To: <1323798248.18910.3.camel@petersburg>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Initial support for ARM V6-M
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Rozenman <Alex_Rozenman@mentor.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel <qemu-devel@nongnu.org>, Paul Brook <paul@codesourcery.com>

Hi,

Am 13.12.2011 18:44, schrieb Alex Rozenman:
> Please review / discuss / push the attched patch. It adds initial
> support for V6-M for ARM and Cortex-M0.

Please send this as an inline patch (git send-email) and cc Peter.

Some comments:

Please rebase against Peter's target-arm branch:

http://git.linaro.org/gitweb?p=3Dpeople/pmaydell/qemu-arm.git;a=3Dshortlo=
g;h=3Drefs/heads/target-arm.next

You can drop V4T and V5 features then.

IS_V7M() does not seem to be used anywhere yet.

Looks good otherwise AFAICT.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg