From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58520)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1RaWxN-0000E1-Br
	for qemu-devel@nongnu.org; Tue, 13 Dec 2011 13:20:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1RaWxJ-0002rW-6W
	for qemu-devel@nongnu.org; Tue, 13 Dec 2011 13:20:01 -0500
Received: from mail-qw0-f52.google.com ([209.85.216.52]:45714)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1RaWxJ-0002rQ-3i
	for qemu-devel@nongnu.org; Tue, 13 Dec 2011 13:19:57 -0500
Received: by qadc11 with SMTP id c11so4938399qad.4
	for <qemu-devel@nongnu.org>; Tue, 13 Dec 2011 10:19:56 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4EE79749.4060703@twiddle.net>
Date: Tue, 13 Dec 2011 10:19:53 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1323798248.18910.3.camel@petersburg>
In-Reply-To: <1323798248.18910.3.camel@petersburg>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Initial support for ARM V6-M
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Rozenman <Alex_Rozenman@mentor.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Paul Brook <paul@codesourcery.com>

On 12/13/2011 09:44 AM, Alex Rozenman wrote:
> +            if (IS_V6M(env))
> +                goto illegal_op;

Also run your patch through scripts/checkpatch.pl.  Which should have
told you that you need braces here and elsewhere.


r~