From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46726)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1RanZi-00067w-Q2
	for qemu-devel@nongnu.org; Wed, 14 Dec 2011 07:04:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1RanZh-0002TF-PM
	for qemu-devel@nongnu.org; Wed, 14 Dec 2011 07:04:42 -0500
Received: from mout.web.de ([212.227.15.4]:56461)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1RanZh-0002Sz-8T
	for qemu-devel@nongnu.org; Wed, 14 Dec 2011 07:04:41 -0500
Message-ID: <4EE89095.80405@web.de>
Date: Wed, 14 Dec 2011 13:03:33 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <1320950407-43512-1-git-send-email-pavel.borzenkov@gmail.com>
	<1320950407-43512-2-git-send-email-pavel.borzenkov@gmail.com>
In-Reply-To: <1320950407-43512-2-git-send-email-pavel.borzenkov@gmail.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] raw-posix: Remove dead code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

Am 10.11.2011 19:40, schrieb Pavel Borzenkov:
> It was commented out since the initial import from svn.
> 
> Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>

This dead code has just been picked up by Paolo for his "Support
mismatched host and guest logical block sizes" series (10/17).

Feel invited to test whether it works as expected on your Mac OS X.

Andreas

> ---
>  block/raw-posix.c |   18 ------------------
>  1 files changed, 0 insertions(+), 18 deletions(-)
> 
> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index a3de373..17e1c6f 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -37,7 +37,6 @@
>  #include <IOKit/storage/IOMediaBSDClient.h>
>  #include <IOKit/storage/IOMedia.h>
>  #include <IOKit/storage/IOCDMedia.h>
> -//#include <IOKit/storage/IOCDTypes.h>
>  #include <CoreFoundation/CoreFoundation.h>
>  #endif
>  
> @@ -279,23 +278,6 @@ static int raw_open(BlockDriverState *bs, const char *filename, int flags)
>      return raw_open_common(bs, filename, flags, 0);
>  }
>  
> -/* XXX: use host sector size if necessary with:
> -#ifdef DIOCGSECTORSIZE
> -        {
> -            unsigned int sectorsize = 512;
> -            if (!ioctl(fd, DIOCGSECTORSIZE, &sectorsize) &&
> -                sectorsize > bufsize)
> -                bufsize = sectorsize;
> -        }
> -#endif
> -#ifdef CONFIG_COCOA
> -        uint32_t blockSize = 512;
> -        if ( !ioctl( fd, DKIOCGETBLOCKSIZE, &blockSize ) && blockSize > bufsize) {
> -            bufsize = blockSize;
> -        }
> -#endif
> -*/
> -
>  /*
>   * Check if all memory in this vector is sector aligned.
>   */