From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RapCP-0005W1-4z for qemu-devel@nongnu.org; Wed, 14 Dec 2011 08:48:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RapCJ-0002HP-J5 for qemu-devel@nongnu.org; Wed, 14 Dec 2011 08:48:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RapCJ-0002E6-CK for qemu-devel@nongnu.org; Wed, 14 Dec 2011 08:48:39 -0500 Message-ID: <4EE8A9F3.8080804@redhat.com> Date: Wed, 14 Dec 2011 14:51:47 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1323784351-25531-1-git-send-email-stefanha@linux.vnet.ibm.com> <1323784351-25531-3-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1323784351-25531-3-git-send-email-stefanha@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 2/9] block: add BlockJob interface for long-running operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Marcelo Tosatti , qemu-devel@nongnu.org, Luiz Capitulino Am 13.12.2011 14:52, schrieb Stefan Hajnoczi: > Signed-off-by: Stefan Hajnoczi > --- > block_int.h | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 83 insertions(+), 0 deletions(-) Why are these functions static inline in the header instead of being implemented in block.c? The other thing I was going to ask, but don't really know to which patch I should reply, is whether we need to take care of bdrv_close/delete while a block job is still running. What happens if you unplug a device that is being streamed? Kevin