From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35797)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RaqnI-00046K-2t
	for qemu-devel@nongnu.org; Wed, 14 Dec 2011 10:30:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RaqnA-0002F3-7a
	for qemu-devel@nongnu.org; Wed, 14 Dec 2011 10:30:56 -0500
Received: from mail-ee0-f45.google.com ([74.125.83.45]:43926)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RaqnA-0002Es-1p
	for qemu-devel@nongnu.org; Wed, 14 Dec 2011 10:30:48 -0500
Received: by eekb45 with SMTP id b45so979382eek.4
	for <qemu-devel@nongnu.org>; Wed, 14 Dec 2011 07:30:47 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4EE8C123.2090902@redhat.com>
Date: Wed, 14 Dec 2011 16:30:43 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1323854540.7671.16.camel@pasglop>
In-Reply-To: <1323854540.7671.16.camel@pasglop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] spapr: Add support for -vga option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, kvm-ppc@vger.kernel.org, David Gibson <dwg@au1.ibm.com>

On 12/14/2011 10:22 AM, Benjamin Herrenschmidt wrote:
> of course you can use -device
> to manually instanciate individual devices.

That's true, however...

> @@ -563,7 +568,9 @@ static void spapr_finalize_fdt(sPAPREnvironment *spapr,
>           }
>       }
>
> -    spapr_populate_chosen_stdout(fdt, spapr->vio_bus);
> +    if (!spapr_has_graphics) {
> +	spapr_populate_chosen_stdout(fdt, spapr->vio_bus);
> +    }
>
>       _FDT((fdt_pack(fdt)));
>

... the stdout-path would still point to the serial console.  Can that 
be fixed somehow?

Paolo