From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54520)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RayuV-0000JL-Ci
	for qemu-devel@nongnu.org; Wed, 14 Dec 2011 19:10:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RayuU-0004ex-GM
	for qemu-devel@nongnu.org; Wed, 14 Dec 2011 19:10:55 -0500
Received: from mail-yw0-f45.google.com ([209.85.213.45]:58552)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RayuU-0004er-Cb
	for qemu-devel@nongnu.org; Wed, 14 Dec 2011 19:10:54 -0500
Received: by yhgg71 with SMTP id g71so2024386yhg.4
	for <qemu-devel@nongnu.org>; Wed, 14 Dec 2011 16:10:53 -0800 (PST)
Message-ID: <4EE93B0A.1000703@codemonkey.ws>
Date: Wed, 14 Dec 2011 18:10:50 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1323854540.7671.16.camel@pasglop> <4EE9199F.80305@codemonkey.ws>
	<1323907246.21839.29.camel@pasglop>
In-Reply-To: <1323907246.21839.29.camel@pasglop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] spapr: Add support for -vga option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: David Gibson <dwg@au1.ibm.com>, Alexander Graf <agraf@suse.de>, kvm-ppc@vger.kernel.org, qemu-devel@nongnu.org

On 12/14/2011 06:00 PM, Benjamin Herrenschmidt wrote:
> On Wed, 2011-12-14 at 15:48 -0600, Anthony Liguori wrote:
>>>        /* USB */
>>>        if (usb_enabled) {
>>>
>> usb_ohci_init_pci(QLIST_FIRST(&spapr->phbs)->host_state.bus, -1);
>>> +     if (spapr_has_graphics) {
>>> +         usbdevice_create("keyboard");
>>> +         usbdevice_create("mouse");
>>
>> It is better to use usb_create() and pass it the usb bus directly as
>> this will make it easier to express this as composition down the road.
>
> How do I do that ? usb_ohci_init_pci() doesn't appear to return
> the USB bus....

Let's make it...  I'll send a patch.

Regards,

Anthony Liguori

>
> Cheers,
> Ben.
>
>
>