From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: spice-devel <spice-devel@lists.freedesktop.org>,
Luiz Capitulino <lcapitulino@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] client_migrate_info - do we need a new command?
Date: Thu, 15 Dec 2011 10:03:54 +0100 [thread overview]
Message-ID: <4EE9B7FA.2040508@redhat.com> (raw)
In-Reply-To: <4EE79722.7070807@codemonkey.ws>
Hi,
> Originally, the command was a normal sync command and my understanding
> is that it simply posted notification to the clients. Apparently, users
> of the interface need to actually know when the client has Ack'd this
> operation because otherwise it's racy since a disconnect may occur
> before the client processes the redirection.
No. The problem is that qemu doesn't process any other I/O while a
incoming migration is running, thats why we have to serialize things:
First have spice client connect to the target (and wait for that op to
finish). Then kick off live migration.
That reminds me that there is another way to fix it: Simply lift the
restriction to not process I/O while the incoming live migration runs,
then the need to serialize goes away.
What is the status here? I remember this being discussed in the past
for other reasons. Also moving migration to a thread would probably
easily allow the I/O thread run in parallel ...
> The trouble with using a async command for this is that the time between
> (1) & (2) may be arbitrarily long. Since most QMP clients today always
> use a NULL tag, that effectively means the monitor is blocked for an
> arbitrarily long time while this operation is in flight.
There is a pretty short timeout (five seconds or so).
cheers,
Gerd
prev parent reply other threads:[~2011-12-15 9:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 18:19 [Qemu-devel] client_migrate_info - do we need a new command? Anthony Liguori
2011-12-13 19:25 ` Luiz Capitulino
2011-12-14 9:26 ` [Qemu-devel] [Spice-devel] " Yonit Halperin
2011-12-14 10:16 ` [Qemu-devel] " Avi Kivity
2011-12-15 9:03 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE9B7FA.2040508@redhat.com \
--to=kraxel@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=spice-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).