From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rb7Yn-0003zb-NW for qemu-devel@nongnu.org; Thu, 15 Dec 2011 04:25:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rb7Yi-0001PH-5y for qemu-devel@nongnu.org; Thu, 15 Dec 2011 04:25:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48092) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rb7Yh-0001PB-RU for qemu-devel@nongnu.org; Thu, 15 Dec 2011 04:25:00 -0500 Message-ID: <4EE9BCE8.8040700@redhat.com> Date: Thu, 15 Dec 2011 11:24:56 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1323879637-16901-1-git-send-email-aliguori@us.ibm.com> <1323879637-16901-5-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1323879637-16901-5-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] memory: move header into include/ and add to QEMU docs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On 12/14/2011 06:20 PM, Anthony Liguori wrote: > Signed-off-by: Anthony Liguori > --- > QEMU-docs.xml | 1 + > include/memory.h | 566 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > memory.h | 566 ------------------------------------------------------ Enable rename detection, this makes the patch much more reviewable. Why the move to include/? I like to keep my headers close. -- error compiling committee.c: too many arguments to function