From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33928) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbBcb-00014C-NL for qemu-devel@nongnu.org; Thu, 15 Dec 2011 08:45:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RbBcW-0007wO-59 for qemu-devel@nongnu.org; Thu, 15 Dec 2011 08:45:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:30664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbBcV-0007wI-TX for qemu-devel@nongnu.org; Thu, 15 Dec 2011 08:45:12 -0500 Message-ID: <4EE9F9E4.5080706@redhat.com> Date: Thu, 15 Dec 2011 15:45:08 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1323879637-16901-1-git-send-email-aliguori@us.ibm.com> <1323879637-16901-5-git-send-email-aliguori@us.ibm.com> <4EE9BCE8.8040700@redhat.com> <4EE9F77A.10401@codemonkey.ws> In-Reply-To: <4EE9F77A.10401@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] memory: move header into include/ and add to QEMU docs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On 12/15/2011 03:34 PM, Anthony Liguori wrote: > On 12/15/2011 03:24 AM, Avi Kivity wrote: >> On 12/14/2011 06:20 PM, Anthony Liguori wrote: >>> Signed-off-by: Anthony Liguori >>> --- >>> QEMU-docs.xml | 1 + >>> include/memory.h | 566 >>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++ >>> memory.h | 566 >>> ------------------------------------------------------ >> >> Enable rename detection, this makes the patch much more reviewable. > > Is there a git config for it? diff.renames true > >> Why the move to include/? I like to keep my headers close. > > See other thread. Yeah. -- error compiling committee.c: too many arguments to function