qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 0/2] Plan obsolescense of exec.c memory functions
Date: Thu, 15 Dec 2011 15:21:12 +0100	[thread overview]
Message-ID: <4EEA0258.7090708@redhat.com> (raw)
In-Reply-To: <1323956131-471-1-git-send-email-avi@redhat.com>

On 12/15/2011 02:35 PM, Avi Kivity wrote:
> Exile some exec.c functions to a private header, to prevent accidental reuse.
>
> Please pull from
>
>    git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/exec-obsolete
>
> Avi Kivity (2):
>    etraxfs_eth: drop bogus cpu_unregister_io_memory()
>    memory: move obsolete exec.c functions to a private header
>
>   cpu-common.h     |   36 -----------------------------
>   exec-obsolete.h  |   66 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   exec.c           |    3 ++
>   hw/etraxfs_eth.c |    3 --
>   memory.c         |    3 ++
>   5 files changed, 72 insertions(+), 39 deletions(-)
>   create mode 100644 exec-obsolete.h

I would prefer exec-private.h or memory-private.h.  Right now, the 
situation is that exec.c provides a low-level interface to memory.c.  If 
the situation changes, the header will disappear.

Paolo

  parent reply	other threads:[~2011-12-15 14:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-15 13:35 [Qemu-devel] [PULL 0/2] Plan obsolescense of exec.c memory functions Avi Kivity
2011-12-15 13:35 ` [Qemu-devel] [PATCH 1/2] etraxfs_eth: drop bogus cpu_unregister_io_memory() Avi Kivity
2011-12-15 13:35 ` [Qemu-devel] [PATCH 2/2] memory: move obsolete exec.c functions to a private header Avi Kivity
2011-12-15 14:21 ` Paolo Bonzini [this message]
2011-12-15 14:22   ` [Qemu-devel] [PULL 0/2] Plan obsolescense of exec.c memory functions Avi Kivity
2011-12-15 14:26     ` Anthony Liguori
2011-12-19 15:01 ` Anthony Liguori
2011-12-19 15:06   ` Avi Kivity
2011-12-19 15:34     ` Avi Kivity
2011-12-19 16:15       ` Anthony Liguori
2011-12-19 17:12         ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EEA0258.7090708@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).