From: Anthony Liguori <anthony@codemonkey.ws>
To: "Benoît Canet" <benoit.canet@gmail.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH v2 0/3] remove sysbus_init_mmio_cb2 usage
Date: Thu, 15 Dec 2011 10:22:14 -0600 [thread overview]
Message-ID: <4EEA1EB6.6020809@codemonkey.ws> (raw)
In-Reply-To: <1323873129-29742-1-git-send-email-benoit.canet@gmail.com>
On 12/14/2011 08:32 AM, Benoît Canet wrote:
> These patches remove sysbus_init_mmio_cb2 usage from the codebase.
Breaks the build:
anthony@titi:~/build/qemu$ make
CC ppc-softmmu/ppce500_mpc8544ds.o
cc1: warnings being treated as errors
/home/anthony/git/qemu/hw/ppce500_mpc8544ds.c: In function ‘mpc8544ds_init’:
/home/anthony/git/qemu/hw/ppce500_mpc8544ds.c:247:19: error: unused variable
‘busdev’
make[1]: *** [ppce500_mpc8544ds.o] Error 1
make: *** [subdir-ppc-softmmu] Error 2
Regards,
Anthony Liguori
>
> v2:
> dont't change ppce500 initialisation method (peter)
>
> Benoît Canet (3):
> sh_pci: remove sysbus_init_mmio_cb2 usage
> ppce500_pci: remove sysbus_init_mmio_cb2 usage
> sysbus: remove sysbus_init_mmio_cb2
>
> hw/ppce500_mpc8544ds.c | 1 +
> hw/ppce500_pci.c | 27 ++++++---------------------
> hw/r2d.c | 14 ++++++++++++--
> hw/sh_pci.c | 29 ++++-------------------------
> hw/sysbus.c | 16 ----------------
> hw/sysbus.h | 5 -----
> 6 files changed, 23 insertions(+), 69 deletions(-)
>
prev parent reply other threads:[~2011-12-15 16:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 14:32 [Qemu-devel] [PATCH v2 0/3] remove sysbus_init_mmio_cb2 usage Benoît Canet
2011-12-14 14:32 ` [Qemu-devel] [PATCH v2 1/3] sh_pci: " Benoît Canet
2011-12-14 14:32 ` [Qemu-devel] [PATCH v2 2/3] ppce500_pci: " Benoît Canet
2011-12-14 14:32 ` [Qemu-devel] [PATCH v2 3/3] sysbus: remove sysbus_init_mmio_cb2 Benoît Canet
2011-12-15 16:22 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEA1EB6.6020809@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=agraf@suse.de \
--cc=benoit.canet@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).