From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbE4f-0003CQ-Nf for qemu-devel@nongnu.org; Thu, 15 Dec 2011 11:22:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RbE4a-0004MJ-7m for qemu-devel@nongnu.org; Thu, 15 Dec 2011 11:22:25 -0500 Received: from mail-iy0-f173.google.com ([209.85.210.173]:47636) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbE4a-0004M7-4l for qemu-devel@nongnu.org; Thu, 15 Dec 2011 11:22:20 -0500 Received: by iagj37 with SMTP id j37so3427102iag.4 for ; Thu, 15 Dec 2011 08:22:19 -0800 (PST) Message-ID: <4EEA1EB6.6020809@codemonkey.ws> Date: Thu, 15 Dec 2011 10:22:14 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1323873129-29742-1-git-send-email-benoit.canet@gmail.com> In-Reply-To: <1323873129-29742-1-git-send-email-benoit.canet@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 0/3] remove sysbus_init_mmio_cb2 usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, agraf@suse.de On 12/14/2011 08:32 AM, Benoît Canet wrote: > These patches remove sysbus_init_mmio_cb2 usage from the codebase. Breaks the build: anthony@titi:~/build/qemu$ make CC ppc-softmmu/ppce500_mpc8544ds.o cc1: warnings being treated as errors /home/anthony/git/qemu/hw/ppce500_mpc8544ds.c: In function ‘mpc8544ds_init’: /home/anthony/git/qemu/hw/ppce500_mpc8544ds.c:247:19: error: unused variable ‘busdev’ make[1]: *** [ppce500_mpc8544ds.o] Error 1 make: *** [subdir-ppc-softmmu] Error 2 Regards, Anthony Liguori > > v2: > dont't change ppce500 initialisation method (peter) > > Benoît Canet (3): > sh_pci: remove sysbus_init_mmio_cb2 usage > ppce500_pci: remove sysbus_init_mmio_cb2 usage > sysbus: remove sysbus_init_mmio_cb2 > > hw/ppce500_mpc8544ds.c | 1 + > hw/ppce500_pci.c | 27 ++++++--------------------- > hw/r2d.c | 14 ++++++++++++-- > hw/sh_pci.c | 29 ++++------------------------- > hw/sysbus.c | 16 ---------------- > hw/sysbus.h | 5 ----- > 6 files changed, 23 insertions(+), 69 deletions(-) >