From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbFnJ-0001GA-Lr for qemu-devel@nongnu.org; Thu, 15 Dec 2011 13:12:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RbFnI-0007LU-FB for qemu-devel@nongnu.org; Thu, 15 Dec 2011 13:12:37 -0500 Message-ID: <4EEA388F.2050008@codemonkey.ws> Date: Thu, 15 Dec 2011 12:12:31 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1323956034-21468-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1323956034-21468-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] HACKING: clarify allocation/free recommendations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-trivial@nongnu.org, Kevin Wolf , patches@linaro.org, qemu-devel@nongnu.org, Stefan Hajnoczi On 12/15/2011 07:33 AM, Peter Maydell wrote: > Clarify the allocation/free recommendations; this is mostly > just tidying up following the global-search-and-replace done > with the conversion to the GLib g_malloc and friends. > > Signed-off-by: Peter Maydell Applied. Thanks. Regards, Anthony Liguori > --- > HACKING | 10 ++++++---- > 1 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/HACKING b/HACKING > index 733eab2..471cf1d 100644 > --- a/HACKING > +++ b/HACKING > @@ -77,11 +77,13 @@ avoided. > > Use of the malloc/free/realloc/calloc/valloc/memalign/posix_memalign > APIs is not allowed in the QEMU codebase. Instead of these routines, > -use the replacement g_malloc/g_malloc0/g_realloc/g_free or > -qemu_vmalloc/qemu_memalign/qemu_vfree APIs. > +use the GLib memory allocation routines g_malloc/g_malloc0/g_new/ > +g_new0/g_realloc/g_free or QEMU's qemu_vmalloc/qemu_memalign/qemu_vfree > +APIs. > > -Please note that NULL check for the g_malloc result is redundant and > -that g_malloc() call with zero size is not allowed. > +Please note that g_malloc will exit on allocation failure, so there > +is no need to test for failure (as you would have to with malloc). > +Calling g_malloc with a zero size is valid and will return NULL. > > Memory allocated by qemu_vmalloc or qemu_memalign must be freed with > qemu_vfree, since breaking this will cause problems on Win32 and user