From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbYIa-0004te-Hn for qemu-devel@nongnu.org; Fri, 16 Dec 2011 08:58:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RbYIU-00025B-Qo for qemu-devel@nongnu.org; Fri, 16 Dec 2011 08:58:08 -0500 Received: from mail-gy0-f173.google.com ([209.85.160.173]:36972) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbYIU-000257-OP for qemu-devel@nongnu.org; Fri, 16 Dec 2011 08:58:02 -0500 Received: by ghbg19 with SMTP id g19so2764080ghb.4 for ; Fri, 16 Dec 2011 05:58:02 -0800 (PST) Message-ID: <4EEB4E66.2030406@codemonkey.ws> Date: Fri, 16 Dec 2011 07:57:58 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1324036918-2405-1-git-send-email-pbonzini@redhat.com> <1324036918-2405-4-git-send-email-pbonzini@redhat.com> In-Reply-To: <1324036918-2405-4-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/8] qom: fix swapped parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, qemu-devel@nongnu.org On 12/16/2011 06:01 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini Yeah, this code path is currently dead as there is no way to test it until we defer s/init/realize/ and defer it to guest launch. In my next series when I introduce Object and move properties into it, we can write some unit tests to cover this sort of thing. Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > hw/qdev.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/qdev.c b/hw/qdev.c > index 83913c7..bda8d6c 100644 > --- a/hw/qdev.c > +++ b/hw/qdev.c > @@ -1110,7 +1110,7 @@ void qdev_property_set(DeviceState *dev, Visitor *v, const char *name, > if (!prop->set) { > error_set(errp, QERR_PERMISSION_DENIED); > } else { > - prop->set(dev, prop->opaque, v, name, errp); > + prop->set(dev, v, prop->opaque, name, errp); > } > } >