From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbYLy-0008PI-Q2 for qemu-devel@nongnu.org; Fri, 16 Dec 2011 09:01:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RbYLx-0003CR-Hc for qemu-devel@nongnu.org; Fri, 16 Dec 2011 09:01:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14985) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbYLx-0003CH-3l for qemu-devel@nongnu.org; Fri, 16 Dec 2011 09:01:37 -0500 Message-ID: <4EEB4F3D.3000006@redhat.com> Date: Fri, 16 Dec 2011 15:01:33 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1324036918-2405-1-git-send-email-pbonzini@redhat.com> <1324036918-2405-6-git-send-email-pbonzini@redhat.com> <4EEB4EE1.5030807@codemonkey.ws> In-Reply-To: <4EEB4EE1.5030807@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/8] qom: introduce QERR_PROPERTY_VALUE_OUT_OF_RANGE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: kwolf@redhat.com, qemu-devel@nongnu.org On 12/16/2011 03:00 PM, Anthony Liguori wrote: >> This will be used when reject invalid values for integer fields that >> are less than 64-bits wide. >> >> Signed-off-by: Paolo Bonzini > > I'd rather use generic errors when possible. How about > VALUE_OUT_OF_RANGE and we can make the message "'%(item)' doesn't take > value..." and pass "%s.%s" % (device, property) for item. Ok. Paolo