From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbYc0-00066c-TX for qemu-devel@nongnu.org; Fri, 16 Dec 2011 09:18:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RbYbw-00069z-JJ for qemu-devel@nongnu.org; Fri, 16 Dec 2011 09:18:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbYbw-00069q-CK for qemu-devel@nongnu.org; Fri, 16 Dec 2011 09:18:08 -0500 Message-ID: <4EEB531C.1060306@redhat.com> Date: Fri, 16 Dec 2011 15:18:04 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1324036918-2405-1-git-send-email-pbonzini@redhat.com> <1324036918-2405-8-git-send-email-pbonzini@redhat.com> <4EEB507B.1080508@codemonkey.ws> In-Reply-To: <4EEB507B.1080508@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 7/8] qom: distinguish "legacy" property type name from QOM type name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: kwolf@redhat.com, qemu-devel@nongnu.org On 12/16/2011 03:06 PM, Anthony Liguori wrote: >> >> - type = g_strdup_printf("legacy<%s>", prop->info->name); >> + type = g_strdup_printf("legacy<%s>", >> + prop->info->legacy_name ?: prop->info->name); > > I think this confuses the legacy type with the legacy property names. > > I think it would be better to do 'legacy-%s' as then it's at least clear > when something is a type name vs. a property name. That's only in 8/8. Here I'm not changing property names yet, note that everything is in prop->info. This patch prepares for when you'll have a legacy type for property legacy, and uint32 for iobase. But I can surely rename legacy to legacy-iobase, if that's what you meant. paolo