From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbYcM-0006mU-Nf for qemu-devel@nongnu.org; Fri, 16 Dec 2011 09:18:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RbYcG-0006G6-VU for qemu-devel@nongnu.org; Fri, 16 Dec 2011 09:18:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38469) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbYcG-0006FZ-JR for qemu-devel@nongnu.org; Fri, 16 Dec 2011 09:18:28 -0500 Message-ID: <4EEB5330.2070605@redhat.com> Date: Fri, 16 Dec 2011 15:18:24 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1324036918-2405-1-git-send-email-pbonzini@redhat.com> <1324036918-2405-7-git-send-email-pbonzini@redhat.com> <4EEB439F.7010601@redhat.com> <4EEB4CD2.8080907@redhat.com> <4EEB503A.5030706@codemonkey.ws> In-Reply-To: <4EEB503A.5030706@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/8] qom: introduce get/set methods for Property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: kwolf@redhat.com, Gerd Hoffmann , qemu-devel@nongnu.org On 12/16/2011 03:05 PM, Anthony Liguori wrote: >> >> I thought the same initially. However, I noticed that the visitor >> interfaces for >> links is also a string. So, even if a block/char/netdev property later >> becomes a >> link<>, the interface would not change. > > The semantics change though. A "drive" link takes a flat block device > name. When it's converted to a link, it will take a QOM path. Since > block devices will exist in their own directory, it will certainly still > be possible to use the flat block device name but since a paths will > also be supported, I think it's best to clearly distinguish the link > based property from the flat block device name property. But it's a superset, no? Paolo