From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbZ3e-0007Cu-UC for qemu-devel@nongnu.org; Fri, 16 Dec 2011 09:46:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RbZ3a-0003Kf-WD for qemu-devel@nongnu.org; Fri, 16 Dec 2011 09:46:46 -0500 Received: from mail-iy0-f173.google.com ([209.85.210.173]:41974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbZ3a-0003KL-Nv for qemu-devel@nongnu.org; Fri, 16 Dec 2011 09:46:42 -0500 Received: by iagj37 with SMTP id j37so5080417iag.4 for ; Fri, 16 Dec 2011 06:46:42 -0800 (PST) Message-ID: <4EEB59CE.809@codemonkey.ws> Date: Fri, 16 Dec 2011 08:46:38 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1324036918-2405-1-git-send-email-pbonzini@redhat.com> <1324036918-2405-2-git-send-email-pbonzini@redhat.com> <4EEB4DE2.2060805@codemonkey.ws> <4EEB4F0C.7050702@redhat.com> <4EEB5152.2010405@codemonkey.ws> <4EEB543C.5030104@redhat.com> In-Reply-To: <4EEB543C.5030104@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/8] qapi: fix NULL pointer dereference List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, qemu-devel@nongnu.org On 12/16/2011 08:22 AM, Paolo Bonzini wrote: > On 12/16/2011 03:10 PM, Anthony Liguori wrote: >> If a property function does not set the Error pointer, it must visit >> something. > > Hmm, then we have to introduce NULL into QJson and visitors. Visitors assume that strings aren't nullable (which is actually true in JSON and in QString). I also think that string properties shouldn't be nullable. Regards, Anthony Liguori > > Paolo >