From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbZML-0006Z2-G9 for qemu-devel@nongnu.org; Fri, 16 Dec 2011 10:06:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RbZMF-0007Yq-UY for qemu-devel@nongnu.org; Fri, 16 Dec 2011 10:06:05 -0500 Received: from mail-iy0-f173.google.com ([209.85.210.173]:35789) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbZMF-0007Yc-RB for qemu-devel@nongnu.org; Fri, 16 Dec 2011 10:05:59 -0500 Received: by iagj37 with SMTP id j37so5102594iag.4 for ; Fri, 16 Dec 2011 07:05:58 -0800 (PST) Message-ID: <4EEB5E52.7090204@codemonkey.ws> Date: Fri, 16 Dec 2011 09:05:54 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1324036918-2405-1-git-send-email-pbonzini@redhat.com> <1324036918-2405-2-git-send-email-pbonzini@redhat.com> <4EEB4DE2.2060805@codemonkey.ws> <4EEB4F0C.7050702@redhat.com> <4EEB5152.2010405@codemonkey.ws> <4EEB543C.5030104@redhat.com> <4EEB59CE.809@codemonkey.ws> <4EEB5A6D.4080705@redhat.com> <4EEB5C11.5040907@codemonkey.ws> <4EEB5DD4.50302@redhat.com> In-Reply-To: <4EEB5DD4.50302@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/8] qapi: fix NULL pointer dereference List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, qemu-devel@nongnu.org On 12/16/2011 09:03 AM, Paolo Bonzini wrote: > On 12/16/2011 03:56 PM, Anthony Liguori wrote: >> I'd really prefer to stick to non-nullable strings as there is no >> obvious way to specify NULL in command line options. > > We can leave it as the default. A property with a non-null default is implicitly > not nullable, which actually makes some sense. We can model this in > get_string/set_string too. > >> What are the uses of null in qdev string properties? I know you can't >> set a string to null since parse() doesn't have a null syntax. So we're >> really just talking about an uninitialized state, right? > > Yes. No ROM BAR is an example of a NULL string property. So it's really filenames and backend names, right? Can we just treat empty strings like NULL? I think all of the various bits handles both the same way. Regards, Anthony Liguori > > Paolo >