From: "Andreas Färber" <andreas.faerber@web.de>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Laurent Vivier <laurent@vivier.eu>,
qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>,
Alex Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH] [RFC] Remove ppc_newworld/ppc_oldworld
Date: Fri, 16 Dec 2011 21:06:53 +0100 [thread overview]
Message-ID: <4EEBA4DD.9090804@web.de> (raw)
In-Reply-To: <1324058938-21392-1-git-send-email-aliguori@us.ibm.com>
Am 16.12.2011 19:08, schrieb Anthony Liguori:
> I notice that these two machines have seem to have never really been touched
> other than tree-wide refactoring since their introduction. Googling for the
> machine types doesn't hit any user questions or comments about the machine
> types.
>
> For the most part, the devices haven't been converted to qdev and are actually
> the only remaining PCI devices that haven't been.
>
> To me this indicates that the code currently isn't being used by anyone. I
> can do the qdev conversions if it is, but as far as I can tell, it's just bit
> rotting right now.
>
> Is this accurate? Can we remove this code? If there is future interest here,
> it's easy enough to revert this, fix up the code, and resubmit.
No. There's an easy explanation why you might not find much mentions of
the machine names: g3beige (ppc_oldworld.c) is the default for
qemu-system-ppc, and mac99 (ppc_newworld.c) is the default for
qemu-system-ppc64.
If there's something ppc you'd like to remove then I would be open about
discussing the current ppc_prep.c machine but not its infrastructure
(prep_pci etc. - there we started a qdev'ification) as that's needed for
40p and bebox machines. I was holding back any refactorings while
MemoryRegion API was a moving target and now QOM didn't seem inviting
either. ;)
Andreas
next prev parent reply other threads:[~2011-12-16 20:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 18:08 [Qemu-devel] [PATCH] [RFC] Remove ppc_newworld/ppc_oldworld Anthony Liguori
2011-12-16 20:06 ` Andreas Färber [this message]
2011-12-16 22:22 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEBA4DD.9090804@web.de \
--to=andreas.faerber@web.de \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).