From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rbe4c-0007vr-NC for qemu-devel@nongnu.org; Fri, 16 Dec 2011 15:08:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rbe4b-00051Z-J1 for qemu-devel@nongnu.org; Fri, 16 Dec 2011 15:08:06 -0500 Received: from mout.web.de ([212.227.15.3]:59714) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rbe4b-00051L-6B for qemu-devel@nongnu.org; Fri, 16 Dec 2011 15:08:05 -0500 Message-ID: <4EEBA4DD.9090804@web.de> Date: Fri, 16 Dec 2011 21:06:53 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1324058938-21392-1-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1324058938-21392-1-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] [RFC] Remove ppc_newworld/ppc_oldworld List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Blue Swirl , Laurent Vivier , qemu-devel@nongnu.org, Aurelien Jarno , Alex Graf Am 16.12.2011 19:08, schrieb Anthony Liguori: > I notice that these two machines have seem to have never really been touched > other than tree-wide refactoring since their introduction. Googling for the > machine types doesn't hit any user questions or comments about the machine > types. > > For the most part, the devices haven't been converted to qdev and are actually > the only remaining PCI devices that haven't been. > > To me this indicates that the code currently isn't being used by anyone. I > can do the qdev conversions if it is, but as far as I can tell, it's just bit > rotting right now. > > Is this accurate? Can we remove this code? If there is future interest here, > it's easy enough to revert this, fix up the code, and resubmit. No. There's an easy explanation why you might not find much mentions of the machine names: g3beige (ppc_oldworld.c) is the default for qemu-system-ppc, and mac99 (ppc_newworld.c) is the default for qemu-system-ppc64. If there's something ppc you'd like to remove then I would be open about discussing the current ppc_prep.c machine but not its infrastructure (prep_pci etc. - there we started a qdev'ification) as that's needed for 40p and bebox machines. I was holding back any refactorings while MemoryRegion API was a moving target and now QOM didn't seem inviting either. ;) Andreas