qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Geoffrey Thomas <geofft@ldpreload.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
	qemu-devel@nongnu.org,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] slirp: Fix typo in net_slirp_hostfwd_remove
Date: Sat, 17 Dec 2011 20:52:46 +0100	[thread overview]
Message-ID: <4EECF30E.9060109@web.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1112170420460.22177@tyger.mit.edu>

[-- Attachment #1: Type: text/plain, Size: 832 bytes --]

On 2011-12-17 10:23, Geoffrey Thomas wrote:
> Report an error when err is nonzero, not when it is zero.
> 
> Signed-off-by: Geoffrey Thomas <geofft@ldpreload.com>
> ---
>  net/slirp.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/slirp.c b/net/slirp.c
> index 6646ecb..18e07ba 100644
> --- a/net/slirp.c
> +++ b/net/slirp.c
> @@ -351,7 +351,7 @@ void net_slirp_hostfwd_remove(Monitor *mon, const
> QDict *qdict)
>                                 host_addr, host_port);
> 
>      monitor_printf(mon, "host forwarding rule for %s %s\n", src_str,
> -                   err ? "removed" : "not found");
> +                   err ? "not found" : "removed");
>      return;
> 
>   fail_syntax:

Oops, obviously. Stefan, should be another trivial one for you.

Thanks,
Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

  reply	other threads:[~2011-12-17 19:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-17  9:23 [Qemu-devel] [PATCH] slirp: Fix typo in net_slirp_hostfwd_remove Geoffrey Thomas
2011-12-17 19:52 ` Jan Kiszka [this message]
2011-12-19 10:48 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EECF30E.9060109@web.de \
    --to=jan.kiszka@web.de \
    --cc=geofft@ldpreload.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).