* [Qemu-devel] [PATCH] slirp: Fix typo in net_slirp_hostfwd_remove
@ 2011-12-17 9:23 Geoffrey Thomas
2011-12-17 19:52 ` Jan Kiszka
2011-12-19 10:48 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Geoffrey Thomas @ 2011-12-17 9:23 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-devel
Report an error when err is nonzero, not when it is zero.
Signed-off-by: Geoffrey Thomas <geofft@ldpreload.com>
---
net/slirp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/slirp.c b/net/slirp.c
index 6646ecb..18e07ba 100644
--- a/net/slirp.c
+++ b/net/slirp.c
@@ -351,7 +351,7 @@ void net_slirp_hostfwd_remove(Monitor *mon, const QDict *qdict)
host_addr, host_port);
monitor_printf(mon, "host forwarding rule for %s %s\n", src_str,
- err ? "removed" : "not found");
+ err ? "not found" : "removed");
return;
fail_syntax:
--
1.7.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] slirp: Fix typo in net_slirp_hostfwd_remove
2011-12-17 9:23 [Qemu-devel] [PATCH] slirp: Fix typo in net_slirp_hostfwd_remove Geoffrey Thomas
@ 2011-12-17 19:52 ` Jan Kiszka
2011-12-19 10:48 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kiszka @ 2011-12-17 19:52 UTC (permalink / raw)
To: Geoffrey Thomas; +Cc: qemu-trivial, qemu-devel, Stefan Hajnoczi
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
On 2011-12-17 10:23, Geoffrey Thomas wrote:
> Report an error when err is nonzero, not when it is zero.
>
> Signed-off-by: Geoffrey Thomas <geofft@ldpreload.com>
> ---
> net/slirp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/slirp.c b/net/slirp.c
> index 6646ecb..18e07ba 100644
> --- a/net/slirp.c
> +++ b/net/slirp.c
> @@ -351,7 +351,7 @@ void net_slirp_hostfwd_remove(Monitor *mon, const
> QDict *qdict)
> host_addr, host_port);
>
> monitor_printf(mon, "host forwarding rule for %s %s\n", src_str,
> - err ? "removed" : "not found");
> + err ? "not found" : "removed");
> return;
>
> fail_syntax:
Oops, obviously. Stefan, should be another trivial one for you.
Thanks,
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] slirp: Fix typo in net_slirp_hostfwd_remove
2011-12-17 9:23 [Qemu-devel] [PATCH] slirp: Fix typo in net_slirp_hostfwd_remove Geoffrey Thomas
2011-12-17 19:52 ` Jan Kiszka
@ 2011-12-19 10:48 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2011-12-19 10:48 UTC (permalink / raw)
To: Geoffrey Thomas; +Cc: Jan Kiszka, qemu-devel
On Sat, Dec 17, 2011 at 04:23:59AM -0500, Geoffrey Thomas wrote:
> Report an error when err is nonzero, not when it is zero.
>
> Signed-off-by: Geoffrey Thomas <geofft@ldpreload.com>
> ---
> net/slirp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-12-19 10:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-17 9:23 [Qemu-devel] [PATCH] slirp: Fix typo in net_slirp_hostfwd_remove Geoffrey Thomas
2011-12-17 19:52 ` Jan Kiszka
2011-12-19 10:48 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).