From: Avi Kivity <avi@redhat.com>
To: Jordan Justen <jljusten@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v9 0/3] PC system flash support
Date: Sun, 18 Dec 2011 12:04:18 +0200 [thread overview]
Message-ID: <4EEDBAA2.7000200@redhat.com> (raw)
In-Reply-To: <CAFe8ug8LJFyYzYMhTk5T+3=EOdeD5eFH7JF-nrcPF795iz_12g@mail.gmail.com>
On 12/15/2011 11:02 PM, Jordan Justen wrote:
> I verified that 'info mtree' and 'info qdev' are equivalent for pc-1.0
> when using master and with my patches.
>
> However, I did discover that v1.0 seems to differ from master for this
> same test.
>
That's are fine; pre-memory-API devices don't show up in info mtree.
> @@ -218,7 +221,7 @@
> dev-prop: data_iobase = 0x511
> irq 0
> mmio ffffffffffffffff/0000000000000002
> - mmio ffffffffffffffff/0000000000000002
> + mmio ffffffffffffffff/0000000000000001
>
This one isn't nice. Doesn't affect pc though.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-12-18 10:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 20:51 [Qemu-devel] [PATCH v9 0/3] PC system flash support Jordan Justen
2011-12-15 20:51 ` [Qemu-devel] [PATCH v9 1/3] pc: Add pc-1.1 machine type Jordan Justen
2011-12-15 20:51 ` [Qemu-devel] [PATCH v9 2/3] pflash: Support read-only mode Jordan Justen
2011-12-15 20:51 ` [Qemu-devel] [PATCH v9 3/3] pc: Support system flash memory with pflash Jordan Justen
2011-12-19 19:41 ` Anthony Liguori
2011-12-19 21:25 ` Jordan Justen
2011-12-19 22:19 ` Anthony Liguori
2012-01-09 9:28 ` Kevin Wolf
2012-01-28 23:13 ` Jordan Justen
2012-02-20 0:39 ` Jordan Justen
2011-12-20 8:11 ` Stefan Hajnoczi
2011-12-15 21:02 ` [Qemu-devel] [PATCH v9 0/3] PC system flash support Jordan Justen
2011-12-18 10:04 ` Avi Kivity [this message]
2011-12-19 18:27 ` Jordan Justen
2011-12-20 10:53 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEDBAA2.7000200@redhat.com \
--to=avi@redhat.com \
--cc=jljusten@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).