From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RcDbU-0001CY-9b for qemu-devel@nongnu.org; Sun, 18 Dec 2011 05:04:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RcDbT-0006IE-8Y for qemu-devel@nongnu.org; Sun, 18 Dec 2011 05:04:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:28967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RcDbS-0006I4-TD for qemu-devel@nongnu.org; Sun, 18 Dec 2011 05:04:23 -0500 Message-ID: <4EEDBAA2.7000200@redhat.com> Date: Sun, 18 Dec 2011 12:04:18 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1323982273-13623-1-git-send-email-jordan.l.justen@intel.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v9 0/3] PC system flash support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jordan Justen Cc: qemu-devel On 12/15/2011 11:02 PM, Jordan Justen wrote: > I verified that 'info mtree' and 'info qdev' are equivalent for pc-1.0 > when using master and with my patches. > > However, I did discover that v1.0 seems to differ from master for this > same test. > That's are fine; pre-memory-API devices don't show up in info mtree. > @@ -218,7 +221,7 @@ > dev-prop: data_iobase = 0x511 > irq 0 > mmio ffffffffffffffff/0000000000000002 > - mmio ffffffffffffffff/0000000000000002 > + mmio ffffffffffffffff/0000000000000001 > This one isn't nice. Doesn't affect pc though. -- error compiling committee.c: too many arguments to function