From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47167) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RcKlv-00070c-GS for qemu-devel@nongnu.org; Sun, 18 Dec 2011 12:43:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RcKlu-0002LX-C4 for qemu-devel@nongnu.org; Sun, 18 Dec 2011 12:43:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RcKlu-0002LT-5T for qemu-devel@nongnu.org; Sun, 18 Dec 2011 12:43:38 -0500 Message-ID: <4EEE2643.1070504@redhat.com> Date: Sun, 18 Dec 2011 19:43:31 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1323467645-24271-1-git-send-email-anthony.perard@citrix.com> <1323467645-24271-6-git-send-email-anthony.perard@citrix.com> <4EE3382D.80903@web.de> <4EE609BF.1070307@siemens.com> <4EE617BA.4030102@siemens.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] early_savevm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: Anthony Perard , Jan Kiszka , Xen Devel , QEMU-devel On 12/13/2011 01:55 PM, Stefano Stabellini wrote: > A bit more context to my suggestion: > > - we open the save state file and check the magic number and the > version number before machine->init(); > > - we add a new set of entries to the save state file that contains > early_savevm functions: they are called before machine->init(); > > - after reaching the end of the early_savevm functions we stop parsing > the save state file and we call machine->init(); > > - after machine->init() is completed we continue parsing the save state > file as usual. I think this is fragile. In the general case you can't describe the framebuffer BAR with just a single number, it may be partially obscured by another BAR. It's better to fix this behind the scenes. -- error compiling committee.c: too many arguments to function