From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49486)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RcejA-0003ns-Km
	for qemu-devel@nongnu.org; Mon, 19 Dec 2011 10:02:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Rcej5-0002xx-4V
	for qemu-devel@nongnu.org; Mon, 19 Dec 2011 10:02:08 -0500
Received: from mail-iy0-f173.google.com ([209.85.210.173]:57284)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Rcej5-0002xd-0J
	for qemu-devel@nongnu.org; Mon, 19 Dec 2011 10:02:03 -0500
Received: by iagj37 with SMTP id j37so9821482iag.4
	for <qemu-devel@nongnu.org>; Mon, 19 Dec 2011 07:02:02 -0800 (PST)
Message-ID: <4EEF51E5.6070700@codemonkey.ws>
Date: Mon, 19 Dec 2011 09:01:57 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1323956131-471-1-git-send-email-avi@redhat.com>
In-Reply-To: <1323956131-471-1-git-send-email-avi@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PULL 0/2] Plan obsolescense of exec.c memory
	functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org

On 12/15/2011 07:35 AM, Avi Kivity wrote:
> Exile some exec.c functions to a private header, to prevent accidental reuse.
>
> Please pull from
>
>    git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/exec-obsolete

This breaks the Xen build.  Perhaps we need to merge your patches to convert Xen 
to the memory API first?

cc1: warnings being treated as errors
/home/anthony/git/qemu/xen-all.c: In function ‘xen_ram_init’:
/home/anthony/git/qemu/xen-all.c:169:5: error: implicit declaration of function 
‘cpu_register_physical_memory’
/home/anthony/git/qemu/xen-all.c:169:5: error: nested extern declaration of 
‘cpu_register_physical_memory’
make[1]: *** [xen-all.o] Error 1

Regards,

Anthony Liguori

>
> Avi Kivity (2):
>    etraxfs_eth: drop bogus cpu_unregister_io_memory()
>    memory: move obsolete exec.c functions to a private header
>
>   cpu-common.h     |   36 -----------------------------
>   exec-obsolete.h  |   66 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   exec.c           |    3 ++
>   hw/etraxfs_eth.c |    3 --
>   memory.c         |    3 ++
>   5 files changed, 72 insertions(+), 39 deletions(-)
>   create mode 100644 exec-obsolete.h
>