From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rcfsp-0007Pd-DG for qemu-devel@nongnu.org; Mon, 19 Dec 2011 11:16:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rcfsi-0000yu-Fs for qemu-devel@nongnu.org; Mon, 19 Dec 2011 11:16:11 -0500 Received: from mail-gx0-f173.google.com ([209.85.161.173]:42948) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rcfsi-0000yc-C6 for qemu-devel@nongnu.org; Mon, 19 Dec 2011 11:16:04 -0500 Received: by ggnk1 with SMTP id k1so4711558ggn.4 for ; Mon, 19 Dec 2011 08:16:03 -0800 (PST) Message-ID: <4EEF633E.2000709@codemonkey.ws> Date: Mon, 19 Dec 2011 10:15:58 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1323956131-471-1-git-send-email-avi@redhat.com> <4EEF51E5.6070700@codemonkey.ws> <4EEF52DC.6080301@redhat.com> <4EEF5974.4080608@redhat.com> In-Reply-To: <4EEF5974.4080608@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PULL 0/2] Plan obsolescense of exec.c memory functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org On 12/19/2011 09:34 AM, Avi Kivity wrote: > On 12/19/2011 05:06 PM, Avi Kivity wrote: >> On 12/19/2011 05:01 PM, Anthony Liguori wrote: >>> On 12/15/2011 07:35 AM, Avi Kivity wrote: >>>> Exile some exec.c functions to a private header, to prevent >>>> accidental reuse. >>>> >>>> Please pull from >>>> >>>> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git >>>> memory/exec-obsolete >>> >>> This breaks the Xen build. Perhaps we need to merge your patches to >>> convert Xen to the memory API first? >>> >>> cc1: warnings being treated as errors >>> /home/anthony/git/qemu/xen-all.c: In function ‘xen_ram_init’: >>> /home/anthony/git/qemu/xen-all.c:169:5: error: implicit declaration of >>> function ‘cpu_register_physical_memory’ >>> /home/anthony/git/qemu/xen-all.c:169:5: error: nested extern >>> declaration of ‘cpu_register_physical_memory’ >>> make[1]: *** [xen-all.o] Error 1 >> >> Yeah, I'll redo and repost. >> > > It's now in the memory/xen and memory/exec-obsolete branches of > qemu-kvm.git (latter based on the former). Pulled both of these. Thanks. Regards, Anthony Liguori >