Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip support

[Anthony Liguori <anthony@codemonkey.ws>]

On 12/19/2011 03:17 PM, Marcelo Tosatti wrote:
>
> Anthony,
>
> Can you please review&  ACK?
>
> You could even apply directly but well do a kvm-autotest run through
> uq/master. Still, your review is needed.

Overall, it looks good except for the backend/frontend split.  This should be 
done in terms of qdev inheritance.  As we progress to QOM, this will mean that 
the various links will just be link<APICCommon> or whatever it ends up being called.

Regards,

Anthony Liguori

>
> Thanks
>
> On Thu, Dec 15, 2011 at 01:33:15PM +0100, Jan Kiszka wrote:
>> Changes in v5:
>> - properly introduce apic_report_irq_delivered (instead of
>>    apic_set_irq_delivered silently)
>> - rework apic to kvm core interface according to Blue's suggestion
>>
>> CC: Lai Jiangshan<laijs@cn.fujitsu.com>
>>
>> Jan Kiszka (16):
>>    msi: Generalize msix_supported to msi_supported
>>    kvm: Move kvmclock into hw/kvm folder
>>    apic: Stop timer on reset
>>    apic: Inject external NMI events via LINT1
>>    apic: Introduce apic_report_irq_delivered
>>    apic: Introduce backend/frontend infrastructure for KVM reuse
>>    apic: Open-code timer save/restore
>>    i8259: Introduce backend/frontend infrastructure for KVM reuse
>>    ioapic: Introduce backend/frontend infrastructure for KVM reuse
>>    memory: Introduce memory_region_init_reservation
>>    kvm: Introduce core services for in-kernel irqchip support
>>    kvm: x86: Establish IRQ0 override control
>>    kvm: x86: Add user space part for in-kernel APIC
>>    kvm: x86: Add user space part for in-kernel i8259
>>    kvm: x86: Add user space part for in-kernel IOAPIC
>>    kvm: Arm in-kernel irqchip support
>>
>>   Makefile.objs                  |    2 +-
>>   Makefile.target                |    6 +-
>>   configure                      |    1 +
>>   hw/apic.c                      |  309 ++++-----------------------------------
>>   hw/apic.h                      |    1 +
>>   hw/apic_common.c               |  312 ++++++++++++++++++++++++++++++++++++++++
>>   hw/apic_internal.h             |  122 ++++++++++++++++
>>   hw/i8259.c                     |  127 ++--------------
>>   hw/i8259_common.c              |  173 ++++++++++++++++++++++
>>   hw/i8259_internal.h            |   82 +++++++++++
>>   hw/ioapic.c                    |  130 ++---------------
>>   hw/ioapic_common.c             |  138 ++++++++++++++++++
>>   hw/ioapic_internal.h           |  106 ++++++++++++++
>>   hw/kvm/apic.c                  |  138 ++++++++++++++++++
>>   hw/{kvmclock.c =>  kvm/clock.c} |    4 +-
>>   hw/{kvmclock.h =>  kvm/clock.h} |    0
>>   hw/kvm/i8259.c                 |  126 ++++++++++++++++
>>   hw/kvm/ioapic.c                |  101 +++++++++++++
>>   hw/msi.c                       |    8 +
>>   hw/msi.h                       |    2 +
>>   hw/msix.c                      |    9 +-
>>   hw/msix.h                      |    2 -
>>   hw/pc.c                        |   19 ++-
>>   hw/pc.h                        |    1 +
>>   hw/pc_piix.c                   |   66 ++++++++-
>>   kvm-all.c                      |  154 ++++++++++++++++++++
>>   kvm-stub.c                     |    5 +
>>   kvm.h                          |   14 ++
>>   memory.c                       |   36 +++++
>>   memory.h                       |   16 ++
>>   monitor.c                      |    6 +-
>>   qemu-config.c                  |    4 +
>>   qemu-options.hx                |    5 +-
>>   sysemu.h                       |    1 -
>>   target-i386/kvm.c              |   49 +++++++
>>   trace-events                   |    2 +-
>>   vl.c                           |    1 -
>>   37 files changed, 1739 insertions(+), 539 deletions(-)
>>   create mode 100644 hw/apic_common.c
>>   create mode 100644 hw/apic_internal.h
>>   create mode 100644 hw/i8259_common.c
>>   create mode 100644 hw/i8259_internal.h
>>   create mode 100644 hw/ioapic_common.c
>>   create mode 100644 hw/ioapic_internal.h
>>   create mode 100644 hw/kvm/apic.c
>>   rename hw/{kvmclock.c =>  kvm/clock.c} (98%)
>>   rename hw/{kvmclock.h =>  kvm/clock.h} (100%)
>>   create mode 100644 hw/kvm/i8259.c
>>   create mode 100644 hw/kvm/ioapic.c
>>
>> --
>> 1.7.3.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe kvm" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>