From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RcmxN-0006F3-9A for qemu-devel@nongnu.org; Mon, 19 Dec 2011 18:49:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RcmxM-00048q-5z for qemu-devel@nongnu.org; Mon, 19 Dec 2011 18:49:21 -0500 Received: from fmmailgate05.web.de ([217.72.192.243]:37368) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RcmxL-00048l-Md for qemu-devel@nongnu.org; Mon, 19 Dec 2011 18:49:20 -0500 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate05.web.de (Postfix) with ESMTP id D6D46682D41B for ; Tue, 20 Dec 2011 00:49:08 +0100 (CET) Message-ID: <4EEFCD71.5040603@web.de> Date: Tue, 20 Dec 2011 00:49:05 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <20111219211737.GA17469@amt.cnet> <4EEFB9AE.7050309@codemonkey.ws> In-Reply-To: <4EEFB9AE.7050309@codemonkey.ws> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig25E0B98AA850F99F7831EDAA" Subject: Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Anthony Liguori , Lai Jiangshan , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcelo Tosatti , qemu-devel , Blue Swirl , Avi Kivity This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig25E0B98AA850F99F7831EDAA Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-12-19 23:24, Anthony Liguori wrote: > On 12/19/2011 03:17 PM, Marcelo Tosatti wrote: >> >> Anthony, >> >> Can you please review& ACK? >> >> You could even apply directly but well do a kvm-autotest run through >> uq/master. Still, your review is needed. >=20 > Overall, it looks good except for the backend/frontend split. This > should be done in terms of qdev inheritance. I cannot follow your idea here yet. There is no inheritance as we end up with only a single class that permutes (selects a different backend) on creation. I'm not sure how to model two classes that will still only mean a single qdev registration. Jan --------------enig25E0B98AA850F99F7831EDAA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7vzXEACgkQitSsb3rl5xSaGgCeIOCvzBzxk+FHaTDUrKKGObai tHgAnigPJCkX1NAS31MWGQ5ksuqiN8aB =dxbs -----END PGP SIGNATURE----- --------------enig25E0B98AA850F99F7831EDAA--