From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60817)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RcndN-0007zv-VK
	for qemu-devel@nongnu.org; Mon, 19 Dec 2011 19:32:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RcndM-0001fu-Vo
	for qemu-devel@nongnu.org; Mon, 19 Dec 2011 19:32:45 -0500
Received: from mail-yw0-f45.google.com ([209.85.213.45]:43466)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RcndM-0001fo-TR
	for qemu-devel@nongnu.org; Mon, 19 Dec 2011 19:32:44 -0500
Received: by yhgg71 with SMTP id g71so5105370yhg.4
	for <qemu-devel@nongnu.org>; Mon, 19 Dec 2011 16:32:44 -0800 (PST)
Message-ID: <4EEFD7A9.3050007@codemonkey.ws>
Date: Mon, 19 Dec 2011 18:32:41 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <cover.1323952402.git.jan.kiszka@siemens.com>	<20111219211737.GA17469@amt.cnet>
	<4EEFB9AE.7050309@codemonkey.ws> <4EEFCD71.5040603@web.de>
In-Reply-To: <4EEFCD71.5040603@web.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic
 irqchip support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>

On 12/19/2011 05:49 PM, Jan Kiszka wrote:
> On 2011-12-19 23:24, Anthony Liguori wrote:
>> On 12/19/2011 03:17 PM, Marcelo Tosatti wrote:
>>>
>>> Anthony,
>>>
>>> Can you please review&   ACK?
>>>
>>> You could even apply directly but well do a kvm-autotest run through
>>> uq/master. Still, your review is needed.
>>
>> Overall, it looks good except for the backend/frontend split.  This
>> should be done in terms of qdev inheritance.
>
> I cannot follow your idea here yet. There is no inheritance as we end up
> with only a single class that permutes (selects a different backend) on
> creation. I'm not sure how to model two classes that will still only
> mean a single qdev registration.

See other reply in thread.

We should model this as two separate qdev devices.  We can avoid regressing 
migration in qemu-kvm by just having a common vmstate name.

apic is a no-user device so there's no way that changing the name of it in 
qemu-kvm can affect users.

Regards,

Anthony Liguori

>
> Jan
>