From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RctVr-0001Pm-Ir for qemu-devel@nongnu.org; Tue, 20 Dec 2011 01:49:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RctVq-0005QC-KX for qemu-devel@nongnu.org; Tue, 20 Dec 2011 01:49:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RctVq-0005Q8-Dr for qemu-devel@nongnu.org; Tue, 20 Dec 2011 01:49:22 -0500 Message-ID: <4EF0300B.8060903@redhat.com> Date: Tue, 20 Dec 2011 14:49:47 +0800 From: Osier Yang MIME-Version: 1.0 References: <1307127842-12102-1-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1307127842-12102-1-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC 00/10]: QMP/HMP: Introduce tray handling commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, amit.shah@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, armbru@redhat.com On 2011=E5=B9=B406=E6=9C=8804=E6=97=A5 03:03, Luiz Capitulino wrote: > In a recent discussion on the mailing list regarding the introduction o= f > the BLOCK_TRAY_OPEN and BLOCK_TRAY_CLOSE events[1], it was mentioned th= at > we need to fix the eject command and maybe introduce new commands first. > > Here's a my proposal. > > This series introduces three new commands: > > o blockdev-tray-open: opens the drive tray. Also Supports removing th= e inserted > media. The BLOCK_TRAY_OPEN event is emitted if this command succeed= s. > o blockdev-tray-close: closes a drive tray. The BLOCK_TRAY_CLOSE even= t is > emitted. > o blockdev-media-insert: Inserts a media in the tray. The tray must e= mpty > and already opened. No event is emitted. > > The existing 'eject' and 'change' commands are completely rewriten in t= erms > of the new commands. Besides fixing some bad behaviors, this also makes= it > possible for the events to be automtically emitted. > > Ejecting a device inside the guest (or closing its tray) also causes th= e > events to be emitted. > > Everything which applies for the virtual tray seems to work as expected= for > the host's tray. But more testing is needed. > Hi, Luiz Does it still plan to introduce new commands for tray & media management? and by the way, I'd agree with Markus more for seperating the commands for tray and media management. It makes thing simpler and more clear from a user's point of view. Regards, Osier